Re: [PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives

Uwe Kleine-König
2015-08-04T15:44:22Z

Hello,

On Mon, Aug 03, 2015 at 07:13:31PM -0700, Guenter Roeck wrote:
> The watchdog infrastructure now supports handling watchdog keepalive
> if the watchdog is running while the watchdog device is closed.
> Convert the driver to use this infrastructure.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/imx2_wdt.c | 72 ++++++++-------------------------------------

I tested the series on an i.MX27 machine and it works nicely. When the
watchdog is already running at probe time it is constantly pinged until
userspace opens /dev/watchdog. With the patch I sent earlier today the
functionallity is also given, that is the machine resets iff I stop
pinging. And when I do a stopping-close the worker looks for this in
hardware non-stoppable device.

Very nice, and also \o/ for the diffstat,
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |