From: Wolfram Sang <wsa@the-dreams.de>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jean Delvare <jdelvare@suse.com>,
Lee Jones <lee.jones@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v3 3/3] iTCO_wdt: Add support for TCO on Intel Sunrisepoint
Date: Thu, 6 Aug 2015 23:08:17 +0200 [thread overview]
Message-ID: <20150806210817.GB1523@katana> (raw)
In-Reply-To: <20150806120024.GG4332@codeblueprint.co.uk>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On Thu, Aug 06, 2015 at 01:00:24PM +0100, Matt Fleming wrote:
> (Sorry for the delay in replying)
>
> On Fri, 31 Jul, at 11:41:04AM, Andy Shevchenko wrote:
> > >
> > > + if (val32 & enable_bit)
> > > + ret = -EIO;
> > > +
> > > return ret; /* returns: 0 = OK, -EIO = Error */
> >
> > What about removing ret at all?
> >
> > if (val32 & enable_bit)
> > return -EIO;
> >
> > return 0;
>
> Yeah, good catch. I'll make this change.
I'd go for the ternary operator here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-08-06 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 21:58 [PATCH v3 0/3] iTCO_wdt: Add support for Intel Sunrisepoint Matt Fleming
2015-07-30 21:58 ` [PATCH v3 1/3] iTCO_wdt: Expose watchdog properties using platform data Matt Fleming
2015-08-05 20:39 ` Darren Hart
2015-07-30 21:59 ` [PATCH v3 2/3] i2c: i801: Create iTCO device on newer Intel PCHs Matt Fleming
2015-07-30 21:59 ` [PATCH v3 3/3] iTCO_wdt: Add support for TCO on Intel Sunrisepoint Matt Fleming
2015-07-31 8:41 ` Andy Shevchenko
2015-08-06 12:00 ` Matt Fleming
2015-08-06 21:08 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806210817.GB1523@katana \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matt.fleming@intel.com \
--cc=matt@codeblueprint.co.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox