public inbox for linux-watchdog@vger.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <panand@redhat.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: dyoung@redhat.com, dzickus@redhat.com,
	linux-watchdog@vger.kernel.org, linux@roeck-us.net
Subject: Re: [PATCH V4 0/2] watchdog: Sysfs status read support
Date: Tue, 6 Oct 2015 12:13:02 +0530	[thread overview]
Message-ID: <20151006064302.GA28829@dhcppc13.redhat.com> (raw)
In-Reply-To: <cover.1441599217.git.panand@redhat.com>

Hi Wim,

I did not see it in v4.3-rc3 Fixes.
This has already been reviewed by Guenter.
Please let me know if I need to do anything more around it.

~Pratyush

On 07/09/2015:09:54:50 AM, Pratyush Anand wrote:
> These patches provide support to read different watchdog device status
> through sysfs interface.
> 
> Changes since V3:
> * Added Reviewed by tag
> * Corrected a checkpatch warning
> 
> Changes since V2:
> * Used static struct class watchdog_class in stead of pointer. It helped in
>  keep using device_create().
> * Above logic was moved to a separate patch.
> * Changed subject line of other patch to look more relevant
> 
> Changes since V1(RFC):
> * Removed keepalive and start ABI
> * timeout is read only now
> * state returns text
> * only supported ABI visible
> * ABI contact changed to MAINTAINER
> * unnecessary mutex removed
> * aligned continuation with '('
> * unnecessary initialization of status (= 0) corrected
> * unnecessary else removed
> * used __ATTRIBUTE_GROUPS
> * removed watchdog_device_create and added functionality in
> * watchdog_dev_register.
> * optimized nowayout_show
> * Now no -EOPNOTSUPP return for timeout read in case of wdd->timeout = 0.
> 
> Pratyush Anand (2):
>   watchdog: Use static struct class watchdog_class in stead of pointer
>   watchdog: Read device status through sysfs attributes
> 
>  Documentation/ABI/testing/sysfs-class-watchdog |  51 ++++++++++
>  drivers/watchdog/watchdog_core.c               |  17 +---
>  drivers/watchdog/watchdog_core.h               |   2 +-
>  drivers/watchdog/watchdog_dev.c                | 136 ++++++++++++++++++++++++-
>  4 files changed, 187 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-class-watchdog
> 
> -- 
> 2.5.0

  parent reply	other threads:[~2015-10-06  6:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07  4:24 [PATCH V4 0/2] watchdog: Sysfs status read support Pratyush Anand
2015-09-07  4:24 ` [PATCH V4 1/2] watchdog: Use static struct class watchdog_class in stead of pointer Pratyush Anand
2015-09-07  4:24 ` [PATCH V4 2/2] watchdog: Read device status through sysfs attributes Pratyush Anand
2015-10-06  6:43 ` Pratyush Anand [this message]
2015-10-06 13:27   ` [PATCH V4 0/2] watchdog: Sysfs status read support Guenter Roeck
2015-11-16  6:01     ` Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151006064302.GA28829@dhcppc13.redhat.com \
    --to=panand@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox