From: Damien Riegel <damien.riegel@savoirfairelinux.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Dinh Nguyen <dinh.linux@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
shawnguo@kernel.org, Sascha Hauer <kernel@pengutronix.de>,
Wim Van Sebroeck <wim@iguana.be>,
Rob Herring <robh+dt@kernel.org>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH 2/4] watchdog: ts4800: add new driver for TS-4800 watchdog
Date: Wed, 28 Oct 2015 12:52:51 -0400 [thread overview]
Message-ID: <20151028165251.GA5948@localhost> (raw)
In-Reply-To: <20151028020501.GA1548@roeck-us.net>
On Tue, Oct 27, 2015 at 07:05:01PM -0700, Guenter Roeck wrote:
> In general, naming a driver for the first chip it supports is not
> problematic. Making it too generic is, on the other side, problematic.
> What are you going to do if ts4900 (or ts4801) implements a different
> watchdog ?
Okay, I will keep the current name.
I noticed that other boards might have their feed register at different
offsets from syscon base. For instance, feed register is at offset 0x6
on TS-4720 and offset 0xE on TS-4800 (syscon registers are 16-bit wide).
So I need to address that as well (it is related to the next point).
Currently, the driver maps all syscon registers even if it uses only one
of them. I was thinking about adding a "syscon" node and define the
watchdog as a child of it, but the syscon driver set
syscon_regmap_config.val_bits to 32. Do I have to create a new driver if
I want to use val_bits = 16, or is there another way ?
Damien
next prev parent reply other threads:[~2015-10-28 17:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 20:33 [PATCH 0/4] Add board support for TS-4800 Damien Riegel
2015-10-27 20:33 ` [PATCH 1/4] of: add vendor prefix for Technologic Systems Damien Riegel
2015-10-30 12:50 ` Arnd Bergmann
2015-10-30 14:17 ` Damien Riegel
2015-10-27 20:33 ` [PATCH 2/4] watchdog: ts4800: add new driver for TS-4800 watchdog Damien Riegel
2015-10-27 21:20 ` Dinh Nguyen
2015-10-27 21:51 ` Damien Riegel
2015-10-28 2:05 ` Guenter Roeck
2015-10-28 16:52 ` Damien Riegel [this message]
2015-10-30 12:53 ` Arnd Bergmann
2015-10-30 14:27 ` Damien Riegel
2015-11-11 23:28 ` Rob Herring
2015-10-27 20:33 ` [PATCH 3/4] ARM: imx_v6_v7_defconfig: add " Damien Riegel
2015-10-27 20:33 ` [PATCH 4/4] ARM: dts: TS-4800: add basic device tree Damien Riegel
2015-11-11 23:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028165251.GA5948@localhost \
--to=damien.riegel@savoirfairelinux.com \
--cc=devicetree@vger.kernel.org \
--cc=dinh.linux@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@savoirfairelinux.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox