Re: [RFC PATCH 01/13] watchdog: core: add restart handler support

[Vivien Didelot <vivien.didelot@savoirfairelinux.com>]

Hi Guenter,

On Nov. Monday 02 (45) 06:25 PM, Guenter Roeck wrote:
> On 11/02/2015 05:36 PM, Damien Riegel wrote:
> >Many watchdog drivers implement the same code to register a restart
> >handler. This patch provides a generic way to set such a function.
> >
> >The patch adds a new restart watchdog operation. If a restart priority
> >greater than 0 is needed, the driver can call
> >watchdog_set_restart_priority to set it.
> >
> >Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> >Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> Makes sense, and good idea. Unless the patch was written by Vivien,
> the second tag should probably be a Reviewed-by: or Acked-by:, though.

We wrote that together, but Damien did most of the work. So I think
Reviewed-by: for me will indeed be most appropriate here.

Also is it OK to include your Reviewed-by: tag in the v1 (given we add
your comments) or not?

Thanks!
-v