From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:34539 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963AbbKCIib (ORCPT ); Tue, 3 Nov 2015 03:38:31 -0500 Received: by wmff134 with SMTP id f134so77985909wmf.1 for ; Tue, 03 Nov 2015 00:38:30 -0800 (PST) Date: Tue, 3 Nov 2015 08:38:17 +0000 From: Lee Jones To: Damien Riegel Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, shawnguo@kernel.org, kernel@pengutronix.de, wim@iguana.be, robh+dt@kernel.org, sameo@linux.intel.com, dinh.linux@gmail.com, linux@roeck-us.net, kernel@savoirfairelinux.com, arnd@arndb.de Subject: Re: [PATCH v2 2/5] mfd: ts4800-syscon: add driver for TS-4800 syscon Message-ID: <20151103083817.GC3503@x1> References: <1446150450-22093-1-git-send-email-damien.riegel@savoirfairelinux.com> <1446150450-22093-3-git-send-email-damien.riegel@savoirfairelinux.com> <20151030175656.GF4058@x1> <20151030200812.GB8666@localhost> <20151102091253.GS4058@x1> <20151102181334.GA7200@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <20151102181334.GA7200@localhost> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Mon, 02 Nov 2015, Damien Riegel wrote: > On Mon, Nov 02, 2015 at 09:12:53AM +0000, Lee Jones wrote: > > [Cc'ing Arnd] > >=20 > > On Fri, 30 Oct 2015, Damien Riegel wrote: > > > On Fri, Oct 30, 2015 at 05:56:56PM +0000, Lee Jones wrote: > > > > On Thu, 29 Oct 2015, Damien Riegel wrote: > > > >=20 > > > > > Driver for TS-4800 syscon. These registers belong to a FPGA t= hat is > > > > > memory mapped and are used for counters, enable various IPs i= n the FPGA, > > > > > control LEDs, control IOs, etc. > > > > >=20 > > > > > Currently, only the watchdog is handled. > > > >=20 > > > > Why do you require your own syscon driver? > > > >=20 > > > > What's wrong with the generic one? > > > >=20 > > >=20 > > > The generic one uses a regmap_config with reg_stride set to 4 and= val_bits > > > to 32. > > >=20 > > > TS-4800 syscon registers are 16-bit wide and must be accessed wit= h 16 > > > bit read and writes: > > > http://wiki.embeddedarm.com/wiki/TS-4800#Syscon > > >=20 > > > I will address the other issues in the next version (split commit= , > > > license issue, style, and superfluous remove). > >=20 > > The Syscon driver was written to be generic so that each > > vendor/platform didn't require their own incarnation. How unique i= s > > the TS-4800? > >=20 > > Perhaps it might be better to supply a generic 16 bit Syscon for > > devices akin to the TS-4800? >=20 > The TS-4800 syscon could use a generic 16-bit syscon. There is nothin= g > specific that requires a driver besides that. >=20 > We could add some optional properties to the generic syscon node to > configure reg_bits, val_bits, and reg_stride (and pad_bits ?). Would > that be a good solution ? Without looking at the ramifications of such an addition, the premise sounds good to me. So long as the current behaviour remains the default. > > Arnd, any opinion on this? --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html