Re: [PATCH v2 2/2] watchdog: imx2_wdt: add set_pretimeout interface

Guenter Roeck
2015-11-04T16:05:51Z

On 11/04/2015 07:46 AM, Vladimir Zapolskiy wrote:
> Hi Robin,
>
> On 03.11.2015 08:11, Robin Gong wrote:
>> Enable set_pretimeout interface and trigger the pretimeout interrupt before
>> watchdog timeout event happen.
>>
>> Signed-off-by: Robin Gong <b38343@freescale.com>
>> ---
>
> [snip]
>
>> +
>> +static irqreturn_t imx2_wdt_isr(int irq, void *dev_id)
>> +{
>> + struct platform_device *pdev = dev_id;
>> + struct watchdog_device *wdog = platform_get_drvdata(pdev);
>> + struct imx2_wdt_device *wdev = watchdog_get_drvdata(wdog);
>> + u32 val;
>> +
>> + regmap_read(wdev->regmap, IMX2_WDT_WICR, &val);
>> + if (val & IMX2_WDT_WICR_WTIS) {
>> + /*clear interrupt status bit*/
>> + regmap_write(wdev->regmap, IMX2_WDT_WICR, val);
>> + panic("pre-timeout:%d, %d Seconds remained\n", wdog->pretimeout,
>> + wdog->timeout - wdog->pretimeout);
>
> I don't think it is a good idea to panic on pretimeout interrupt, for
> instance pretimeout interrupt may be used for any other purposes - ping
> watchdog, dump some system information before reboot and so on.
>
> In general I am even not completely convinced that the pretimeout interrupt
> handler should be placed in the driver, it may happen that there are some
> users outside, who wants to get this interrupt and act according to the event.
>

Ah yes, this is one of the reasons why adding this functionality into the
watchdog core keeps going nowhere. Some of the people involved absolutely
insist that a watchdog pretimeout should result in a panic, others are just
as strongly opposed to it. At the end, there is no consensus, and we end up
doing nothing, since nothing is better than each driver behaving differently.

Just like politics, I guess :-(.

Guenter