Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: Denis Turischev <denis.turischev@compulab.co.il>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Wim Van Sebroeck <wim@iguana.be>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	Vincent Wan <vincent.wan@amd.com>, Tony Li <tony.li@amd.com>
Subject: Re: [PATCH] sp5100_tco: Add AMD Mullins platform support
Date: Mon, 23 Nov 2015 11:35:51 +0800	[thread overview]
Message-ID: <20151123033549.GA2666@hr-amur2> (raw)
In-Reply-To: <565182B0.9070604@compulab.co.il>

On Sun, Nov 22, 2015 at 10:54:08AM +0200, Denis Turischev wrote:
> Hi Rui,
> 
> On 11/20/2015 04:33 AM, Huang Rui wrote:
> > Hi Denis,
> > 
> > On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
> >> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> >> reuse the existent sp5100_tco driver.
> >>
> > 
> > Thank you to add this support!
> > Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
> > on AMD mullins but also on many other AMD platforms. Could you please
> > share some test method to me, that I am glad to do some quick tests. :)
> 
> My device is Compulabs's fitlet. It's a fanless mini PC, also known as mintbox mini.
> http://fit-pc.com/wiki/index.php/Fit-PC_Product_Line:_fitlet
> Processor's datasheet:
> http://support.amd.com/TechDocs/52740_16h_Models_30h-3Fh_BKDG.pdf
> 
> The dmesg output:
> sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver v0.05
> sp5100_tco: PCI Revision ID: 0x42
> sp5100_tco: Using 0xfeb00000 for watchdog MMIO address
> sp5100_tco: Last reboot was not triggered by watchdog.
> sp5100_tco: initialized (0xffffc90000702000). heartbeat=60 sec (nowayout=0)
> 

I verified it in my side. Thank you. :)
And found AMD new Carrizo platform also supported sp5100_tco watchdog.
I will send a patch to add support to KernCZ(Carrizo) chipset later.

Tested-by: Huang Rui <ray.huang@amd.com>

  reply	other threads:[~2015-11-23  3:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19  9:56 [PATCH] sp5100_tco: Add AMD Mullins platform support Denis Turischev
2015-11-19 16:13 ` Guenter Roeck
2015-11-20  2:33 ` Huang Rui
2015-11-22  8:54   ` Denis Turischev
2015-11-23  3:35     ` Huang Rui [this message]
2015-11-23  7:59 ` [PATCH v2] " Denis Turischev
2015-11-23 16:53   ` Guenter Roeck
2015-11-24  8:46     ` [PATCH v3] " Denis Turischev
2015-11-24 13:52       ` Guenter Roeck
2015-12-27 19:44       ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151123033549.GA2666@hr-amur2 \
    --to=ray.huang@amd.com \
    --cc=bp@alien8.de \
    --cc=denis.turischev@compulab.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=tony.li@amd.com \
    --cc=vincent.wan@amd.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox