From: Wim Van Sebroeck <wim@iguana.be>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>, linux-watchdog@vger.kernel.org
Subject: Re: [watchdog-next] watchdog: kill unref/ref ops
Date: Mon, 11 Jan 2016 22:28:01 +0100 [thread overview]
Message-ID: <20160111212801.GC6613@spo001.leaseweb.nl> (raw)
In-Reply-To: <1451820757-8840-1-git-send-email-tomas.winkler@intel.com>
Hi Tomas,
> ref/unref ops are not called at all so even marked them as deprecated
> is misleading, we need to just drop the API.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> include/linux/watchdog.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 850af04fe0c7..aaabd4703b46 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -47,8 +47,6 @@ struct watchdog_ops {
> int (*set_timeout)(struct watchdog_device *, unsigned int);
> unsigned int (*get_timeleft)(struct watchdog_device *);
> int (*restart)(struct watchdog_device *);
> - void (*ref)(struct watchdog_device *) __deprecated;
> - void (*unref)(struct watchdog_device *) __deprecated;
> long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long);
> };
>
> --
> 2.4.3
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
prev parent reply other threads:[~2016-01-11 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 11:32 [watchdog-next] watchdog: kill unref/ref ops Tomas Winkler
2016-01-03 15:48 ` Guenter Roeck
2016-01-04 23:38 ` Winkler, Tomas
2016-01-04 23:58 ` Guenter Roeck
2016-01-11 21:28 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111212801.GC6613@spo001.leaseweb.nl \
--to=wim@iguana.be \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox