From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-watchdog@vger.kernel.org, kernel@pengutronix.de
Subject: watchdog max63xx driver doesn't match datasheet?
Date: Fri, 15 Jan 2016 11:49:36 +0100 [thread overview]
Message-ID: <20160115104936.GA4778@pengutronix.de> (raw)
Hello Marc,
when comparing the driver drivers/watchdog/max63xx_wdt.c (in Linux 4.4)
with the datasheet
https://datasheets.maximintegrated.com/en/ds/MAX6369-MAX6374.pdf I
wonder if I have a different documentation that you had back in 2009
when you wrote the driver. According to "my" datasheet these chips have
3 logic inputs SET1, SET2 and SET3 and depending on these the timeout is
configured. In your driver however you do:
wdt->base = devm_ioremap_resource(&p->dev, mem);
and to select the timeout you write a byte to this address.
The driver seems to be used in arch/arm/mach-ixp4xx/vulcan-setup.c and
arch/arm/mach-pxa/zeus.c and I guess there the device sits behind some
hardware that sets an output for each bit set in the respective
register.
Did I get this right? If so, a patch to extend the driver to have a
binding like:
{
compatible = "maxim,max6371";
set-gpios = <&gpio1 12 0>, ...;
wdi-gpios = <&gpio3 ...>, ...;
}
would be fine, right?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next reply other threads:[~2016-01-15 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 10:49 Uwe Kleine-König [this message]
2016-01-15 11:21 ` watchdog max63xx driver doesn't match datasheet? Marc Zyngier
2016-01-15 14:21 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115104936.GA4778@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).