Re: [PATCH 00/33] Compile-time stack metadata validation

Josh Poimboeuf
2016-02-24T16:32:54Z

On Wed, Feb 24, 2016 at 08:40:54AM +0100, Ingo Molnar wrote:
>
> * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> > Hi Ingo,
> >
> > On Tue, Feb 23, 2016 at 09:14:06AM +0100, Ingo Molnar wrote:
> > > So I tried out this latest stacktool series and it looks mostly good for an
> > > upstream merge.
> > >
> > > To help this effort move forward I've applied the preparatory/fix patches that are
> > > part of this series to tip:x86/debug - that's 26 out of 31 patches. (I've
> > > propagated all the acks that the latest submission got into the changelogs.)
> >
> > Thanks very much for your review and for applying the fixes!
> >
> > A few issues relating to the merge:
> >
> > - The tip:x86/debug branch fails to build because it depends on
> > ec5186557abb ("x86/asm: Add C versions of frame pointer macros") which
> > is in tip:x86/asm.
>
> Indeed...

FYI, v17 will be based on tip:x86/debug. But note that, when run
against that branch, it'll spit out a lot of these warnings:

objtool: arch/x86/ia32/sys_ia32.o: __ex_table size not a multiple of 12
objtool: arch/x86/ia32/ia32_signal.o: __ex_table size not a multiple of 12
objtool: arch/x86/entry/common.o: __ex_table size not a multiple of 12

Those warnings mean it's expecting the new exception table format which
was added in:

548acf19234d ("x86/mm: Expand the exception table logic to allow new handling options")

So that commit is needed to avoid the warnings.

Thanks!

--
Josh