From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:60117 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933358AbcBQAJn (ORCPT ); Tue, 16 Feb 2016 19:09:43 -0500 Date: Tue, 16 Feb 2016 16:09:38 -0800 From: Guenter Roeck To: Fu Wei Cc: Rob Herring , =?utf-8?B?UGF3ZcWC?= Moll , Mark Rutland , Ian Campbell , Kumar Gala , Wim Van Sebroeck , Jon Corbet , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , LKML , linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Richard Ruigrok , "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , Dave Young , Pratyush Anand , G Gregory , Al Stone , Hanjun Guo , Jon Masters , Arnd Bergmann , Leo Duran , Sudeep Holla Subject: Re: [PATCH v12 4/4] Watchdog: introduce ARM SBSA watchdog driver Message-ID: <20160217000938.GA19355@roeck-us.net> References: <1455611785-2407-1-git-send-email-fu.wei@linaro.org> <1455611785-2407-5-git-send-email-fu.wei@linaro.org> <56C34076.1020206@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Wed, Feb 17, 2016 at 12:33:24AM +0800, Fu Wei wrote: [ ... ] > >>> +MODULE_AUTHOR("Fu Wei "); > >>> +MODULE_AUTHOR("Suravee Suthikulpanit "); > >>> +MODULE_AUTHOR("Al Stone "); > >>> +MODULE_AUTHOR("Timur Tabi "); > >>> +MODULE_LICENSE("GPL v2"); > >>> > >> Do you need a MODULE_ALIAS ? > > > > For now, I thinks we don't need it, Hope I didn't miss something :-) > > Because this module can be mounted automatically with dtb or ACPI(if > > apply my GTDT patch). > > Do you have any suggestion or concern? :-) > > re-think about that , will add > MODULE_ALIAS("platform:sbsa-gwdt"); > > Do you agree ? :-) > Sure. Guenter