From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:47951 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755500AbcBWAQI (ORCPT ); Mon, 22 Feb 2016 19:16:08 -0500 Date: Mon, 22 Feb 2016 16:16:07 -0800 From: Guenter Roeck To: Justin Chen Cc: Jean Delvare , linux-watchdog@vger.kernel.org, Wim Van Sebroeck Subject: Re: [PATCH] watchdog: Add hardware dependency to BCM7038 driver Message-ID: <20160223001607.GB1215@roeck-us.net> References: <20160222121132.665b1f77@endymion> <56CB1FE5.8080206@roeck-us.net> <1456166636.4629.119.camel@chaos.site> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Mon, Feb 22, 2016 at 11:16:30AM -0800, Justin Chen wrote: > On Mon, Feb 22, 2016 at 10:43 AM, Jean Delvare wrote: > > Hello Justin, > > > > Le Monday 22 February 2016 à 09:58 -0800, Justin Chen a écrit : > >> This driver is based off of a Broadcom watchdog block, it is not tied > >> to the MIPS core. > >> The watchdog driver is named BCM7038 because that was the first chip > >> that featured this watchdog block. Their are other chips that use this > >> driver that are not MIPS based. > > > > The Kconfig help text doesn't say this at all. With the current wording > > there is no reason why anyone would enable this option if not building a > > kernel for the Broadcom BCM7038. > Sorry about that! I can submit a patch to fix this. > > > > Which other systems reuse this watchdog block exactly? In the kernel > > tree I can't see anyone instantiating this device. > BRCMSTB chips use this block as well as other BCM chips. > > "This driver is for a watchdog block contained in all Broadcom Set-top > Box chips since BCM7038. BCM7038 was made public during the 2004 CES, > and since then, many chips use this watchdog block including some cable > modem chips." That is a bit vague. Can you be more specific ? Also, while the driver may not be limited to MIPS, I am relatively sure that it has some architecture limits. MIPS, ARM, and ARM64, maybe ? Thanks, Guenter