From: Wolfram Sang <wsa@the-dreams.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0
Date: Thu, 3 Mar 2016 09:12:42 +0100 [thread overview]
Message-ID: <20160303081242.GA1552@katana> (raw)
In-Reply-To: <20160303042618.GB4578@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
> > + if (!dev->clk_rate)
> > + return -EINVAL;
>
> May be a nitpick, but clk_disable_unprepare() is missing.
Oh, definately not a nitpick in my book, will resend! Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-03-03 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 22:33 [PATCH 0/6] treewide: test clock rate to avoid division by 0 Wolfram Sang
2016-03-02 22:33 ` [PATCH 5/6] watchdog: atlas7_wdt: " Wolfram Sang
2016-03-03 4:25 ` Guenter Roeck
2016-03-06 9:09 ` Wim Van Sebroeck
2016-03-02 22:33 ` [PATCH 6/6] watchdog: tangox_wdt: " Wolfram Sang
2016-03-03 4:26 ` Guenter Roeck
2016-03-03 8:12 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303081242.GA1552@katana \
--to=wsa@the-dreams.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).