From: Guenter Roeck <linux@roeck-us.net>
To: Sylvain Lemieux <slemieux.tyco@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
manabian@gmail.com, linux-watchdog@vger.kernel.org,
wim@iguana.be, stigge@antcom.de, vz@mleia.com
Subject: Re: [PATCH v7 6/6] arm: lpc32xx: remove restart handler
Date: Fri, 4 Mar 2016 15:18:57 -0800 [thread overview]
Message-ID: <20160304231857.GC31027@roeck-us.net> (raw)
In-Reply-To: <1457117050-13543-7-git-send-email-slemieux.tyco@gmail.com>
On Fri, Mar 04, 2016 at 01:44:10PM -0500, Sylvain Lemieux wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
>
> Remove the restart handler from "mach-lpc32xx";
> this functionality is now available in the
> pnx4008 watchdog driver.
>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changes from v6 to v7:
> - none.
>
> Changes from v5 to v6:
> - none.
>
> Changes from v4 to v5:
> - none.
>
> Changes from v3 to v4:
> - Switch patch #5 and #6 order.
>
> Changes from v2 to v3:
> - move the change to "phy3250.c" into a separate patch.
>
> Changes from v1 to v2:
> - new patch in v2.
>
> arch/arm/mach-lpc32xx/common.c | 15 ---------------
> arch/arm/mach-lpc32xx/common.h | 1 -
> 2 files changed, 16 deletions(-)
>
> diff --git a/arch/arm/mach-lpc32xx/common.c b/arch/arm/mach-lpc32xx/common.c
> index 716e83e..5b7a1e7 100644
> --- a/arch/arm/mach-lpc32xx/common.c
> +++ b/arch/arm/mach-lpc32xx/common.c
> @@ -194,21 +194,6 @@ void __init lpc32xx_map_io(void)
> iotable_init(lpc32xx_io_desc, ARRAY_SIZE(lpc32xx_io_desc));
> }
>
> -void lpc23xx_restart(enum reboot_mode mode, const char *cmd)
> -{
> - /* Make sure WDT clocks are enabled */
> - __raw_writel(LPC32XX_CLKPWR_PWMCLK_WDOG_EN,
> - LPC32XX_CLKPWR_TIMER_CLK_CTRL);
> -
> - /* Instant assert of RESETOUT_N with pulse length 1mS */
> - __raw_writel(13000, io_p2v(LPC32XX_WDTIM_BASE + 0x18));
> - __raw_writel(0x70, io_p2v(LPC32XX_WDTIM_BASE + 0xC));
> -
> - /* Wait for watchdog to reset system */
> - while (1)
> - ;
> -}
> -
> static int __init lpc32xx_check_uid(void)
> {
> u32 uid[4];
> diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h
> index 1cd8853..2d90801 100644
> --- a/arch/arm/mach-lpc32xx/common.h
> +++ b/arch/arm/mach-lpc32xx/common.h
> @@ -30,7 +30,6 @@ extern void lpc32xx_timer_init(void);
> extern void __init lpc32xx_init_irq(void);
> extern void __init lpc32xx_map_io(void);
> extern void __init lpc32xx_serial_init(void);
> -extern void lpc23xx_restart(enum reboot_mode, const char *);
>
>
> /*
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2016-03-04 23:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 18:44 [PATCH v7 0/6] watchdog: pnx4008: add restart handler Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 1/6] watchdog: pnx4008: update logging during power-on Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 2/6] watchdog: pnx4008: add restart handler Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 3/6] watchdog: pnx4008: add support for soft reset Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 4/6] watchdog: pnx4008: restart: support "cmd" from userspace Sylvain Lemieux
2016-03-04 23:14 ` Guenter Roeck
2016-03-04 18:44 ` [PATCH v7 5/6] arm: lpc32xx: phy3250 remove restart hook Sylvain Lemieux
2016-03-04 23:18 ` Guenter Roeck
2016-03-04 18:44 ` [PATCH v7 6/6] arm: lpc32xx: remove restart handler Sylvain Lemieux
2016-03-04 23:18 ` Guenter Roeck [this message]
2016-03-06 9:51 ` [PATCH v7 0/6] watchdog: pnx4008: add " Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304231857.GC31027@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=slemieux.tyco@gmail.com \
--cc=stigge@antcom.de \
--cc=vz@mleia.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).