From: Borislav Petkov <bp@alien8.de>
To: "河合英宏 / KAWAI,HIDEHIRO" <hidehiro.kawai.ez@hitachi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Mingarelli <thomas.mingarelli@hpe.com>,
Wim Van Sebroeck <wim@iguana.be>, Corey Minyard <minyard@acm.org>,
Javi Merino <javi.merino@arm.com>, Michal Hocko <mhocko@suse.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Nazarewicz <mina86@mina86.com>,
Michal Hocko <mhocko@kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Gobinda Charan Maji <gobinda.cemk07@gmail.com>,
Tejun Heo <tj@kernel.org>,
Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
"openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
Thomas Gleixner <tglx@linutronix.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [v3 PATCH 1/3] panic: Change nmi_panic from macro to function
Date: Mon, 7 Mar 2016 12:13:01 +0100 [thread overview]
Message-ID: <20160307111300.GA27820@pd.tnic> (raw)
In-Reply-To: <04EAB7311EE43145B2D3536183D1A84454B18988@GSjpTKYDCembx31.service.hitachi.net>
On Mon, Mar 07, 2016 at 10:53:51AM +0000, 河合英宏 / KAWAI,HIDEHIRO wrote:
> > From: Borislav Petkov [mailto:bp@alien8.de]
> > On Thu, Mar 03, 2016 at 07:57:44PM +0900, Hidehiro Kawai wrote:
> > > Change nmi_panic() macro to a normal function for the portability.
> >
> > portability?
>
> I wanted to say encapsulating things into a function makes modules
> only have to know about the function. Modules don't need to know
> all things in the macro. But I thought again, and `portability'
> was not appropriate.
>
> However, this patch set has been queued into -mm now. So I'll
> leave this if not necessary.
Unless Andrew is willing to do a quick "quilt header -e" on your patch
and paste in a corrected commit message text which you give him...
:-)
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-07 11:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:57 [v3 PATCH 0/3] Use nmi_panic() in panic on NMI case Hidehiro Kawai
2016-03-03 10:57 ` [v3 PATCH 1/3] panic: Change nmi_panic from macro to function Hidehiro Kawai
2016-03-03 13:14 ` Borislav Petkov
2016-03-07 10:53 ` 河合英宏 / KAWAI,HIDEHIRO
2016-03-07 11:13 ` Borislav Petkov [this message]
2016-03-04 17:49 ` Michal Hocko
2016-03-04 19:27 ` Michal Nazarewicz
2016-03-03 10:57 ` [v3 PATCH 2/3] ipmi/watchdog: Use nmi_panic() when kernel panics in NMI handler Hidehiro Kawai
2016-03-03 10:57 ` [v3 PATCH 3/3] hpwdt: " Hidehiro Kawai
2016-03-03 12:17 ` Guenter Roeck
2016-03-07 11:07 ` [Openipmi-developer] " 河合英宏 / KAWAI,HIDEHIRO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307111300.GA27820@pd.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=gobinda.cemk07@gmail.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mina86@mina86.com \
--cc=minyard@acm.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thomas.mingarelli@hpe.com \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).