From: rcochran@linutronix.de
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, rt@linutronix.de
Subject: Re: watchdog: octeon: missing FROZEN hot plug notifier actions
Date: Thu, 17 Mar 2016 09:08:20 +0100 [thread overview]
Message-ID: <20160317080820.GA32637@linutronix.de> (raw)
In-Reply-To: <56EA21FE.6040009@roeck-us.net>
On Wed, Mar 16, 2016 at 08:18:22PM -0700, Guenter Roeck wrote:
> On 03/16/2016 01:51 PM, rcochran@linutronix.de wrote:
> >
> >In drivers/watchdog/octeon-wdt-main.c, the hot plug notifier callback,
> >octeon_wdt_cpu_callback, does not handle events with CPU_TASKS_FROZEN
> >set in the action code.
> >
> >Is this on purpose? If so, then why is it done that way?
> >
>
> What do you expect it to do ?
I would expect that the driver handles FROZEN in the same way,
enabling and disabling the watchdog interrupt on the hot plugged CPU.
It looks like an oversight that FROZEN actions are ignored, but I
wanted to be sure.
> My understanding is that CPU_TASKS_FROZEN is related to suspend/resume operations,
> which are not really common for typical applications using Octeon CPUs. If they now
> are, it might be worthwhile thinking about adding suspend/resume support to the driver.
Are they merely not common, or is suspend impossible on this machine?
Even if the use case is uncommon, still the driver should be correct.
Thanks,
Richard
next prev parent reply other threads:[~2016-03-17 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 20:51 watchdog: octeon: missing FROZEN hot plug notifier actions rcochran
2016-03-17 3:18 ` Guenter Roeck
2016-03-17 8:08 ` rcochran [this message]
2016-03-17 13:04 ` Guenter Roeck
2016-03-17 13:51 ` rcochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317080820.GA32637@linutronix.de \
--to=rcochran@linutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rt@linutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).