From: Wolfram Sang <wsa@the-dreams.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/4] watchdog: renesas-wdt: add driver
Date: Fri, 1 Apr 2016 13:36:30 +0200 [thread overview]
Message-ID: <20160401113629.GA2513@katana> (raw)
In-Reply-To: <20160330233411.GA24844@roeck-us.net>
Hi Guenter,
> > +static bool nowayout = WATCHDOG_NOWAYOUT;
> > +module_param(nowayout, bool, S_IRUGO);
>
> Sure you want this parameter readable ? No problem with me, but it is unusual,
> so I figure it is worth asking.
No reason, will stick to the usual case.
> > +static void rwdt_write(struct rwdt_priv *priv, u32 val, unsigned reg)
>
> Please use 'unsigned int' throughout.
Can do. May I ask why?
> > + rwdt_write(priv, 65536 - wdev->timeout * priv->clks_per_sec, RWTCNT);
> > +
>
> Just wondering, does reading RWTCNT return the remaining timeout ?
> If so, you could easily implement WDIOC_GETTIMEOUT.
I assume you mean GETTIMELEFT. Tried that, seems to work.
> function. In other words, you can just drop rwdt_set_timeout() entirely.
Cool news! Works fine.
Thanks for the prompt review! Will send V2 in a minute.
Wolfram
next prev parent reply other threads:[~2016-04-01 11:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:28 [PATCH 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs Wolfram Sang
2016-03-30 15:28 ` [PATCH 1/4] watchdog: renesas-wdt: add driver Wolfram Sang
2016-03-30 23:34 ` Guenter Roeck
2016-04-01 11:36 ` Wolfram Sang [this message]
2016-04-01 12:35 ` Guenter Roeck
2016-03-30 15:28 ` [PATCH 2/4] arm64: dts: r8a7795: Add RWDT node Wolfram Sang
2016-03-31 13:42 ` Sergei Shtylyov
2016-04-01 11:39 ` Wolfram Sang
2016-03-30 15:28 ` [PATCH 3/4] arm64: dts: salvator-x: Enable watchdog timer Wolfram Sang
2016-03-30 15:28 ` [PATCH 4/4] arm64: defconfig: enable Renesas Watchdog Timer Wolfram Sang
2016-04-04 8:42 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401113629.GA2513@katana \
--to=wsa@the-dreams.de \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox