From: Guenter Roeck <linux@roeck-us.net>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Clemens Gruber <clemens.gruber@pqgruber.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: core: Fix circular locking dependency
Date: Thu, 21 Apr 2016 16:30:32 -0700 [thread overview]
Message-ID: <20160421233032.GA30063@roeck-us.net> (raw)
In-Reply-To: <20160421155055.503e6d23@lxorguk.ukuu.org.uk>
On Thu, Apr 21, 2016 at 03:50:55PM +0100, One Thousand Gnomes wrote:
> > Turns out the call to cancel_delayed_work_sync() in watchdog_release()
> > is not necessary and can be dropped. If the worker is no longer necessary,
> > the subsequent call to watchdog_update_worker() will cancel it. If it is
> > already running, it won't do anything, since the worker function checks
> > if it needs to ping the watchdog or not.
>
> Is this actually true. Consider the pathalogical case of the device being
> closed and the modue unloaded. In that case the close completes, we drop
> the module count but could still do work on it.
>
Module unload is handled separately and also calls cancel_delayed_work_sync().
Guenter
next prev parent reply other threads:[~2016-04-21 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 14:38 [PATCH] watchdog: core: Fix circular locking dependency Guenter Roeck
2016-04-21 14:50 ` One Thousand Gnomes
2016-04-21 23:30 ` Guenter Roeck [this message]
2016-05-09 13:53 ` Clemens Gruber
2016-05-09 14:18 ` Guenter Roeck
2016-05-14 16:41 ` Wim Van Sebroeck
2016-05-14 17:07 ` Guenter Roeck
2016-05-14 17:24 ` Guenter Roeck
2016-05-14 18:29 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421233032.GA30063@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clemens.gruber@pqgruber.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).