From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Wim Van Sebroeck <wim@iguana.be>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-testers@vger.kernel.org, linux-watchdog@vger.kernel.org,
Chris Mason <clm@fb.com>
Subject: Re: [PATCH] watchdog: dw_wdt: dont build for avr32
Date: Sat, 30 Apr 2016 19:38:28 +0100 [thread overview]
Message-ID: <20160430183828.GC25043@sudip-laptop> (raw)
In-Reply-To: <20160412180128.GA6965@roeck-us.net>
On Tue, Apr 12, 2016 at 11:01:28AM -0700, Guenter Roeck wrote:
> On Tue, Apr 12, 2016 at 05:58:20PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 12, 2016 at 4:39 PM, Sudip Mukherjee
> > <sudipm.mukherjee@gmail.com> wrote:
> > > On Tuesday 12 April 2016 06:36 PM, Guenter Roeck wrote:
> > >>
> > >> On 04/11/2016 10:51 PM, Sudip Mukherjee wrote:
> > >>>
> > >>> The build of avr32 allmodconfig fails with the error:
> > >>> ERROR: "__avr32_udiv64" [drivers/watchdog/kempld_wdt.ko] undefined!
> > >>>
> > >> This means there is a direct 64 bit divide operation in the driver,
> > >> which we should identify and fix.
> >
> > This driver will quite likely never be used on AVR32. Do we need to
> > fix this due to some other architectures?
> >
> > > yes, there is.
> > >
> > > in function: kempld_wdt_set_stage_timeout()
> > > remainder = do_div(stage_timeout64, prescaler);
> >
> > > Any idea how to fix it?
> >
> > Not easy, however, prescaler value is ((1 << 21) - 1) which someone
> > might consider as (1 << 21) with lost in precision.
> >
> > Thus, shift on 20 bits right, add last bit to the value and shift on 1
> > bit right more.
> >
> Sorry, I am missing something. do_div() should work fine with any 32 bit value
> as divisor, no matter what that value is. Why does it fail here ? And why does
> it work if I pass 0x1fffff as second parameter to do_div() directly ?
Please let me know what i can do here to help solve the problem.
linux-next continues to fail for avr32, and to make matters worse we
also have the similar problem in btrfs.
ERROR: "__avr32_udiv64" [fs/btrfs/btrfs.ko] undefined!
ERROR: "__avr32_udiv64" [drivers/watchdog/kempld_wdt.ko] undefined!
Adding Chris to CC if he has some idea how to solve this error for btrfs.
Build log for next-20160429 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/126581065
regards
sudip
next prev parent reply other threads:[~2016-04-30 18:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 5:51 [PATCH] watchdog: dw_wdt: dont build for avr32 Sudip Mukherjee
2016-04-12 13:06 ` Guenter Roeck
2016-04-12 13:39 ` Sudip Mukherjee
2016-04-12 14:58 ` Andy Shevchenko
2016-04-12 15:29 ` Sudip Mukherjee
2016-04-12 18:01 ` Guenter Roeck
2016-04-12 18:17 ` Andy Shevchenko
2016-04-30 18:38 ` Sudip Mukherjee [this message]
2016-05-01 0:04 ` Guenter Roeck
2016-05-01 0:36 ` Guenter Roeck
2016-05-01 1:13 ` Guenter Roeck
2016-05-01 9:04 ` Sudip Mukherjee
2016-05-01 14:09 ` Guenter Roeck
2016-05-01 16:30 ` Sudip Mukherjee
2016-04-12 13:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160430183828.GC25043@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=clm@fb.com \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).