[PATCH] watchdog: hpwdt: update HPE maintainer

[PATCH] watchdog: hpwdt: update HPE maintainer

[Brian Boylston]

Update the HPE maintainer of the hpwdt driver.

Signed-off-by: Brian Boylston <brian.boylston@hpe.com>
---
This patch applies on top of:
[PATCH V4] watchdog: hpwdt: Adjust documentation to match latest kernel module parameters.
which I think is already in linux-watchdog-next.

 Documentation/watchdog/hpwdt.txt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/watchdog/hpwdt.txt b/Documentation/watchdog/hpwdt.txt
index a40398c..27106ff 100644
--- a/Documentation/watchdog/hpwdt.txt
+++ b/Documentation/watchdog/hpwdt.txt
@@ -1,9 +1,12 @@
-Last reviewed: 04/04/2016
+Last reviewed: 05/20/2016
 
                      HPE iLO NMI Watchdog Driver
               NMI sourcing for iLO based ProLiant Servers
                      Documentation and Driver by
-              Thomas Mingarelli <thomas.mingarelli@hpe.com>
+                         Thomas Mingarelli
+
+                       Currently maintained by
+               Brian Boylston <brian.boylston@hpe.com>
 
  The HPE iLO NMI Watchdog driver is a kernel module that provides basic
  watchdog functionality and the added benefit of NMI sourcing. Both the
@@ -95,4 +98,3 @@ Last reviewed: 04/04/2016
 
 
  -- Tom Mingarelli
-    (thomas.mingarelli@hpe.com)
-- 
2.8.3

Re: [PATCH] watchdog: hpwdt: update HPE maintainer

[Guenter Roeck]

Hi Brian,

On 05/23/2016 06:33 AM, Brian Boylston wrote:
> Update the HPE maintainer of the hpwdt driver.
>
> Signed-off-by: Brian Boylston <brian.boylston@hpe.com>

A driver's maintainer is commonly updated in MAINTAINERS, not in the driver itself.
If you are the formal maintainer, I would suggest to add an entry for the driver
into the MAINTAINERS file; this would ensure that you get copied on patches
affecting the driver.

Thanks,
Guenter

> ---
> This patch applies on top of:
> [PATCH V4] watchdog: hpwdt: Adjust documentation to match latest kernel module parameters.
> which I think is already in linux-watchdog-next.
>
>   Documentation/watchdog/hpwdt.txt | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/watchdog/hpwdt.txt b/Documentation/watchdog/hpwdt.txt
> index a40398c..27106ff 100644
> --- a/Documentation/watchdog/hpwdt.txt
> +++ b/Documentation/watchdog/hpwdt.txt
> @@ -1,9 +1,12 @@
> -Last reviewed: 04/04/2016
> +Last reviewed: 05/20/2016
>
>                        HPE iLO NMI Watchdog Driver
>                 NMI sourcing for iLO based ProLiant Servers
>                        Documentation and Driver by
> -              Thomas Mingarelli <thomas.mingarelli@hpe.com>
> +                         Thomas Mingarelli
> +
> +                       Currently maintained by
> +               Brian Boylston <brian.boylston@hpe.com>
>
>    The HPE iLO NMI Watchdog driver is a kernel module that provides basic
>    watchdog functionality and the added benefit of NMI sourcing. Both the
> @@ -95,4 +98,3 @@ Last reviewed: 04/04/2016
>
>
>    -- Tom Mingarelli
> -    (thomas.mingarelli@hpe.com)
>

RE: [PATCH] watchdog: hpwdt: update HPE maintainer

[Boylston, Brian]

Guenter Roeck wrote on 2016-05-23:
> Hi Brian,
> 
> On 05/23/2016 06:33 AM, Brian Boylston wrote:
>> Update the HPE maintainer of the hpwdt driver.
>> 
>> Signed-off-by: Brian Boylston <brian.boylston@hpe.com>
> 
> A driver's maintainer is commonly updated in MAINTAINERS, not in the driver itself.
> If you are the formal maintainer, I would suggest to add an entry for the driver
> into the MAINTAINERS file; this would ensure that you get copied on patches
> affecting the driver.

Thanks, Guenter.  I'll work on an update to MAINTAINERS.
Okay if I leave my name out of hpwdt.txt then?

Brian

> 
> Thanks,
> Guenter
> 
>> ---
>> This patch applies on top of:
>> [PATCH V4] watchdog: hpwdt: Adjust documentation to match latest kernel module parameters.
>> which I think is already in linux-watchdog-next.
>> 
>>   Documentation/watchdog/hpwdt.txt | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>> diff --git a/Documentation/watchdog/hpwdt.txt b/Documentation/watchdog/hpwdt.txt
>> index a40398c..27106ff 100644
>> --- a/Documentation/watchdog/hpwdt.txt
>> +++ b/Documentation/watchdog/hpwdt.txt
>> @@ -1,9 +1,12 @@
>> -Last reviewed: 04/04/2016
>> +Last reviewed: 05/20/2016
>> 
>>                        HPE iLO NMI Watchdog Driver NMI sourcing for iLO
>>                        based ProLiant Servers Documentation and Driver
>>                        by
>> -              Thomas Mingarelli <thomas.mingarelli@hpe.com>
>> +                         Thomas Mingarelli
>> +
>> +                       Currently maintained by
>> +               Brian Boylston <brian.boylston@hpe.com>
>> 
>>    The HPE iLO NMI Watchdog driver is a kernel module that provides basic
>>    watchdog functionality and the added benefit of NMI sourcing. Both the
>> @@ -95,4 +98,3 @@ Last reviewed: 04/04/2016
>> 
>> 
>>    -- Tom Mingarelli
>> -    (thomas.mingarelli@hpe.com)
>> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] watchdog: hpwdt: update HPE maintainer

[Guenter Roeck]

On Mon, May 23, 2016 at 07:38:46PM +0000, Boylston, Brian wrote:
> Guenter Roeck wrote on 2016-05-23:
> > Hi Brian,
> > 
> > On 05/23/2016 06:33 AM, Brian Boylston wrote:
> >> Update the HPE maintainer of the hpwdt driver.
> >> 
> >> Signed-off-by: Brian Boylston <brian.boylston@hpe.com>
> > 
> > A driver's maintainer is commonly updated in MAINTAINERS, not in the driver itself.
> > If you are the formal maintainer, I would suggest to add an entry for the driver
> > into the MAINTAINERS file; this would ensure that you get copied on patches
> > affecting the driver.
> 
> Thanks, Guenter.  I'll work on an update to MAINTAINERS.
> Okay if I leave my name out of hpwdt.txt then?
> 
Hi Brian,

hpwdt.txt is irrelevant when it comes to maintainers. In general I would
recommend to not list e-mail addresses in documentation, or anything else that
isn't static, such as the name of a driver maintainer. It just adds another
place which needs to be updated. So, yes, sure it is ok to not mention your
name there. You can list your name if you like, but please not as "current
maintainer".

Thanks,
Guenter