From: Wolfram Sang <wsa@the-dreams.de>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v4 6/7] watchdog: pretimeout: add option to select a pretimeout governor in runtime
Date: Mon, 29 Aug 2016 20:54:42 +0200 [thread overview]
Message-ID: <20160829185441.GE1610@katana> (raw)
In-Reply-To: <1472227681-1405-7-git-send-email-vladimir_zapolskiy@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
> +static struct governor_priv *find_governor_by_name(const char *gov_name)
> +{
> + struct governor_priv *priv;
> +
> + list_for_each_entry(priv, &governor_list, entry)
> + if (!strncmp(gov_name, priv->gov->name,
strncmp forces to use 'echo -n' in userspace which can cause confusion
when if '-n' is forgotten. The cpufreq code pre-parses the buffer with
sscanf() to eliminate the terminating newline. There is also
sysfs_streq() which seems the a tad better solution to me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-29 18:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 16:07 [PATCH v4 0/7] watchdog: add watchdog pretimeout framework Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 1/7] watchdog: add pretimeout support to the core Vladimir Zapolskiy
2016-08-29 18:50 ` Wolfram Sang
2016-08-29 19:58 ` Vladimir Zapolskiy
2016-08-29 20:30 ` Guenter Roeck
2016-08-26 16:07 ` [PATCH v4 2/7] fs: compat_ioctl: add pretimeout functions for watchdogs Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 3/7] watchdog: add watchdog pretimeout governor framework Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 4/7] watchdog: pretimeout: add panic pretimeout governor Vladimir Zapolskiy
2016-08-29 18:48 ` Wolfram Sang
2016-08-29 19:57 ` Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 5/7] watchdog: pretimeout: add noop " Vladimir Zapolskiy
2016-08-29 18:49 ` Wolfram Sang
2016-08-26 16:08 ` [PATCH v4 6/7] watchdog: pretimeout: add option to select a pretimeout governor in runtime Vladimir Zapolskiy
2016-08-29 18:54 ` Wolfram Sang [this message]
2016-08-29 19:56 ` Vladimir Zapolskiy
2016-08-26 16:08 ` [PATCH v4 7/7] watchdog: pretimeout: add pretimeout_available_governors attribute Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829185441.GE1610@katana \
--to=wsa@the-dreams.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=vladimir_zapolskiy@mentor.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).