From: Guenter Roeck <linux@roeck-us.net>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Robin Gong <b38343@freescale.com>
Subject: Re: [PATCH v4 1/7] watchdog: add pretimeout support to the core
Date: Mon, 29 Aug 2016 13:30:02 -0700 [thread overview]
Message-ID: <20160829203002.GA15280@roeck-us.net> (raw)
In-Reply-To: <e9c4fb76-5b26-ab1e-09a3-d1af57451203@mentor.com>
On Mon, Aug 29, 2016 at 10:58:57PM +0300, Vladimir Zapolskiy wrote:
> On 08/29/2016 09:50 PM, Wolfram Sang wrote:
> >>+ } else {
> >> wdd->timeout = timeout;
> >>+ /* Disable pretimeout if it doesn't fit the new timeout */
> >>+ if (wdd->pretimeout >= wdd->timeout)
> >>+ wdd->pretimeout = 0;
> >
> >I wonder if we should add a warning here? What do you think?
> >
>
> IMHO it is not vitally needed, but some message on KERN_INFO level may
> be considered as user-friendly, watchdog subsystem and drivers are
> historically verbose. Guenter, do you have an opinion on the topic?
>
Yes, I dislike noise, I think the kernel is already way too noisy, and I dislike
statements like "watchdog subsystem and drivers are historically verbose" as
argument for adding more noise.
If this is an error, the function should return an error to user space.
If it isn't an error, I don't see a need for a message.
Guenter
next prev parent reply other threads:[~2016-08-29 20:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 16:07 [PATCH v4 0/7] watchdog: add watchdog pretimeout framework Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 1/7] watchdog: add pretimeout support to the core Vladimir Zapolskiy
2016-08-29 18:50 ` Wolfram Sang
2016-08-29 19:58 ` Vladimir Zapolskiy
2016-08-29 20:30 ` Guenter Roeck [this message]
2016-08-26 16:07 ` [PATCH v4 2/7] fs: compat_ioctl: add pretimeout functions for watchdogs Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 3/7] watchdog: add watchdog pretimeout governor framework Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 4/7] watchdog: pretimeout: add panic pretimeout governor Vladimir Zapolskiy
2016-08-29 18:48 ` Wolfram Sang
2016-08-29 19:57 ` Vladimir Zapolskiy
2016-08-26 16:07 ` [PATCH v4 5/7] watchdog: pretimeout: add noop " Vladimir Zapolskiy
2016-08-29 18:49 ` Wolfram Sang
2016-08-26 16:08 ` [PATCH v4 6/7] watchdog: pretimeout: add option to select a pretimeout governor in runtime Vladimir Zapolskiy
2016-08-29 18:54 ` Wolfram Sang
2016-08-29 19:56 ` Vladimir Zapolskiy
2016-08-26 16:08 ` [PATCH v4 7/7] watchdog: pretimeout: add pretimeout_available_governors attribute Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829203002.GA15280@roeck-us.net \
--to=linux@roeck-us.net \
--cc=b38343@freescale.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
--cc=wim@iguana.be \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).