* [PATCH] watchdog: ath79_wdt: fix build failure
@ 2016-10-05 5:28 Sudip Mukherjee
2016-10-05 13:18 ` Guenter Roeck
2016-10-05 22:35 ` Al Viro
0 siblings, 2 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2016-10-05 5:28 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: linux-kernel, linux-watchdog, Sudip Mukherjee, Al Viro
The build of mips ath79_defconfig was failing with the error:
drivers/watchdog/ath79_wdt.c:164:5:
error: implicit declaration of function 'get_user'
drivers/watchdog/ath79_wdt.c:196:3:
error: implicit declaration of function 'copy_to_user'
drivers/watchdog/ath79_wdt.c:201:3:
error: implicit declaration of function 'put_user'
Quoting Al Viro - "another victim of indirect include chains"
Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/164834126
drivers/watchdog/ath79_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/ath79_wdt.c b/drivers/watchdog/ath79_wdt.c
index 835d310..e2209bf 100644
--- a/drivers/watchdog/ath79_wdt.c
+++ b/drivers/watchdog/ath79_wdt.c
@@ -35,6 +35,7 @@
#include <linux/err.h>
#include <linux/of.h>
#include <linux/of_platform.h>
+#include <linux/uaccess.h>
#define DRIVER_NAME "ath79-wdt"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: ath79_wdt: fix build failure
2016-10-05 5:28 [PATCH] watchdog: ath79_wdt: fix build failure Sudip Mukherjee
@ 2016-10-05 13:18 ` Guenter Roeck
2016-10-05 22:35 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2016-10-05 13:18 UTC (permalink / raw)
To: Sudip Mukherjee, Wim Van Sebroeck; +Cc: linux-kernel, linux-watchdog, Al Viro
On 10/04/2016 10:28 PM, Sudip Mukherjee wrote:
> The build of mips ath79_defconfig was failing with the error:
> drivers/watchdog/ath79_wdt.c:164:5:
> error: implicit declaration of function 'get_user'
> drivers/watchdog/ath79_wdt.c:196:3:
> error: implicit declaration of function 'copy_to_user'
> drivers/watchdog/ath79_wdt.c:201:3:
> error: implicit declaration of function 'put_user'
>
> Quoting Al Viro - "another victim of indirect include chains"
>
> Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/164834126
>
> drivers/watchdog/ath79_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/ath79_wdt.c b/drivers/watchdog/ath79_wdt.c
> index 835d310..e2209bf 100644
> --- a/drivers/watchdog/ath79_wdt.c
> +++ b/drivers/watchdog/ath79_wdt.c
> @@ -35,6 +35,7 @@
> #include <linux/err.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> +#include <linux/uaccess.h>
>
> #define DRIVER_NAME "ath79-wdt"
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: ath79_wdt: fix build failure
2016-10-05 5:28 [PATCH] watchdog: ath79_wdt: fix build failure Sudip Mukherjee
2016-10-05 13:18 ` Guenter Roeck
@ 2016-10-05 22:35 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Al Viro @ 2016-10-05 22:35 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Wim Van Sebroeck, Guenter Roeck, linux-kernel, linux-watchdog
On Wed, Oct 05, 2016 at 10:58:38AM +0530, Sudip Mukherjee wrote:
> The build of mips ath79_defconfig was failing with the error:
> drivers/watchdog/ath79_wdt.c:164:5:
> error: implicit declaration of function 'get_user'
> drivers/watchdog/ath79_wdt.c:196:3:
> error: implicit declaration of function 'copy_to_user'
> drivers/watchdog/ath79_wdt.c:201:3:
> error: implicit declaration of function 'put_user'
>
> Quoting Al Viro - "another victim of indirect include chains"
>
> Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
That was actually fixed in today's -next...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-05 22:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-05 5:28 [PATCH] watchdog: ath79_wdt: fix build failure Sudip Mukherjee
2016-10-05 13:18 ` Guenter Roeck
2016-10-05 22:35 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).