From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
Magnus Lilja <lilja.magnus@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v1] watchdog: imx2: fix hang-up on boot for i.MX21, i.MX27 and i.MX31 SoCs
Date: Thu, 29 Dec 2016 23:04:45 +0100 [thread overview]
Message-ID: <20161229220445.x23gcp5aaw2fz7cv@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5CBfiRMicxvGyHrm-rQFzn8yEQyb5=t49PBr6rdpZYPug@mail.gmail.com>
On Wed, Dec 28, 2016 at 09:39:51PM -0200, Fabio Estevam wrote:
> On Wed, Dec 28, 2016 at 7:46 PM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>
> > Right, so they would fall back to the i.MX21 type and not profit from
> > Markus' change until either the dtb is updated or the third commit is
> > added. I'll try to contact Markus to ask if he remembers more details.
>
> There is no profit from Markus' change for mx21/mx27/mx31.
Ack. If you teach the driver now about i.MX35 and only make use of the WMCR
register on this one, the possible breakage is that this register isn't
written to on the i.MX35 type until the dtb is updated.
> As Vladimir explained in his commit log these SoCs do not have the
> WMCR register, which causes a hang on these SoCs when we try to write
> to it.
So this should be fixed by adding support for i.MX35.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-12-29 22:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 1:06 [PATCH v1] watchdog: imx2: fix hang-up on boot for i.MX21, i.MX27 and i.MX31 SoCs Vladimir Zapolskiy
2016-12-11 2:18 ` Guenter Roeck
2016-12-11 8:58 ` Magnus Lilja
2016-12-11 9:35 ` Uwe Kleine-König
2016-12-11 10:01 ` Vladimir Zapolskiy
2016-12-11 10:26 ` Uwe Kleine-König
2016-12-11 11:21 ` Vladimir Zapolskiy
2016-12-11 12:28 ` Uwe Kleine-König
2016-12-23 1:55 ` Guenter Roeck
2016-12-23 8:20 ` Vladimir Zapolskiy
2016-12-23 8:32 ` Uwe Kleine-König
2016-12-23 9:27 ` Vladimir Zapolskiy
2016-12-23 10:01 ` Uwe Kleine-König
2016-12-23 11:21 ` Vladimir Zapolskiy
2016-12-23 14:11 ` Uwe Kleine-König
2016-12-24 5:08 ` Vladimir Zapolskiy
2016-12-28 20:54 ` Uwe Kleine-König
2016-12-28 21:33 ` Fabio Estevam
2016-12-28 21:46 ` Uwe Kleine-König
2016-12-28 23:39 ` Fabio Estevam
2016-12-29 22:04 ` Uwe Kleine-König [this message]
2016-12-29 23:40 ` Fabio Estevam
2016-12-24 13:00 ` Fabio Estevam
2016-12-28 20:38 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229220445.x23gcp5aaw2fz7cv@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lilja.magnus@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=shawnguo@kernel.org \
--cc=vz@mleia.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).