Re: [PATCH v2] watchdog: intel-mid_wdt: Keep watchdog running

[Guenter Roeck <linux@roeck-us.net>]

On Fri, Mar 10, 2017 at 07:26:57PM +0200, Andy Shevchenko wrote:
> On Fri, 2017-03-10 at 09:16 -0800, Guenter Roeck wrote:
> > On Fri, Mar 10, 2017 at 07:05:49PM +0200, Andy Shevchenko wrote:
> > > On Fri, 2017-03-10 at 18:51 +0200, Andy Shevchenko wrote:
> 
> > > > +	/*
> > > > +	 * Make sure the watchdog is serviced.
> > > > +	 *
> > > > +	 * The firmware followed by U-Boot leaves the watchdog
> > > > running
> > > > +	 * with the default threshold 60 seconds. Our default
> > > > timeout
> > > > is
> > > > +	 * 90 seconds, but internal worker divides it by two,
> > > > which
> > > > is
> > > > +	 * 45 seconds and should be enough (less by 15 seconds
> > > > than
> > > > +	 * threshold).
> > > > +	 */
> > > > +	set_bit(WDOG_HW_RUNNING, &wdt_dev->status);
> > > 
> > > Giving one more thought here perhaps more robust will be to start
> > > watchdog unconditionally here?
> > 
> > Yes, that would be another option, and it sounds like a good idea.
> > Let me know if you want to do that.
> 
> Yes, I prefer it over the rest of solutions.
> 
Ok, I'll wait for v3 of the patch.

Thanks,
Guenter