From: Guenter Roeck <linux@roeck-us.net>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: davinci: Handle return value of clk_prepare_enable
Date: Wed, 7 Jun 2017 13:49:06 -0700 [thread overview]
Message-ID: <20170607204906.GA29222@roeck-us.net> (raw)
In-Reply-To: <79da4d6a88384de0b9d8dcea9fc49ca696273576.1496744110.git.arvind.yadav.cs@gmail.com>
On Tue, Jun 06, 2017 at 03:47:53PM +0530, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/davinci_wdt.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
> index 0e731d7..1ba9ead 100644
> --- a/drivers/watchdog/davinci_wdt.c
> +++ b/drivers/watchdog/davinci_wdt.c
> @@ -173,7 +173,11 @@ static int davinci_wdt_probe(struct platform_device *pdev)
> return PTR_ERR(davinci_wdt->clk);
> }
>
> - clk_prepare_enable(davinci_wdt->clk);
> + ret = clk_prepare_enable(davinci_wdt->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to prepare clock\n");
> + return ret;
> + }
>
> platform_set_drvdata(pdev, davinci_wdt);
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-07 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 10:17 [PATCH] watchdog: davinci: Handle return value of clk_prepare_enable Arvind Yadav
2017-06-07 20:49 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607204906.GA29222@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).