From: Guenter Roeck <linux@roeck-us.net>
To: Christopher Bostic <cbostic@linux.vnet.ibm.com>
Cc: wim@iguana.be, joel@jms.id.au, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, andrew@aj.id.au
Subject: Re: [1/2] drivers/watchdog: Document new aspeed optional dev tree properties.
Date: Sat, 24 Jun 2017 15:07:22 -0700 [thread overview]
Message-ID: <20170624220722.GA3621@roeck-us.net> (raw)
In-Reply-To: <20170613203818.17399-2-cbostic@linux.vnet.ibm.com>
On Tue, Jun 13, 2017 at 03:38:17PM -0500, Christopher Bostic wrote:
> Describe new optional property 'external-signal'. When present in the
> system device tree an exernal signal is generated on watchdog timeout.
>
> Describe new optional property 'no-system-reset'. When present in the
> system device tree no system reset is to occur on watchdog timeout.
> System reset in this case is managed by one of the other watchogs
> available.
>
> Signed-off-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>
This requires DT maintainer approval, but DT maintainers were not copied.
Please resend and use scripts/get_maintainer.pl to determine who to send
it to.
Guenter
> ---
> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> index c5e74d7..4099ea5 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> @@ -8,9 +8,20 @@ Required properties:
> - reg: physical base address of the controller and length of memory mapped
> region
>
> +Optional properties:
> + - external-signal: If the property is present then an external signal is to
> + be generated on watchdog timeout. If absent, external signal is not
> + generated.
> +
> + - no-system-reset: If the property is present then system will not be reset
> + on watchdog timeout. In this case one of the other watchdogs will handle
> + reset. If absent then the watchdog resets the system on timeout.
> +
> Example:
>
> wdt1: watchdog@1e785000 {
> compatible = "aspeed,ast2400-wdt";
> reg = <0x1e785000 0x1c>;
> + external-signal;
> + no-system-reset;
> };
next prev parent reply other threads:[~2017-06-24 22:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 20:38 [PATCH 0/2] drivers/watchdog ASPEED: Add optional dev tree configs Christopher Bostic
2017-06-13 20:38 ` [PATCH 1/2] drivers/watchdog: Document new aspeed optional dev tree properties Christopher Bostic
2017-06-24 22:07 ` Guenter Roeck [this message]
2017-06-27 2:16 ` [1/2] " Christopher Bostic
2017-06-27 2:59 ` [PATCH 1/2] " Joel Stanley
2017-06-27 19:44 ` Christopher Bostic
2017-06-13 20:38 ` [PATCH 2/2] drivers/watchdog: ASPEED reference dev tree properties for config Christopher Bostic
2017-06-24 22:17 ` [2/2] " Guenter Roeck
2017-06-27 2:17 ` Christopher Bostic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624220722.GA3621@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=cbostic@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).