From: Lee Jones <lee.jones@linaro.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it,
alexandre.belloni@free-electrons.com, wim@iguana.be,
linux@roeck-us.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-rtc@vger.kernel.org,
Moritz Fischer <moritz.fischer@ettus.com>
Subject: Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device
Date: Tue, 18 Jul 2017 10:22:45 +0100 [thread overview]
Message-ID: <20170718092245.tc5oosbbb6lzvqpy@dell> (raw)
In-Reply-To: <20170717181409.GB8750@tyrael.ni.corp.natinst.com>
On Mon, 17 Jul 2017, Moritz Fischer wrote:
> Hi Lee,
>
> On Mon, Jul 17, 2017 at 08:51:17AM +0100, Lee Jones wrote:
> > On Thu, 13 Jul 2017, Moritz Fischer wrote:
> >
> > > From: Moritz Fischer <moritz.fischer@ettus.com>
> > >
> > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger.
> > > The device can either be configured as simple RTC, as simple RTC with
> > > Alarm (IRQ) as well as simple RTC with watchdog timer.
> > >
> > > Break up the old monolithic driver in drivers/rtc/rtc-ds1374.c into:
> > > - rtc part in drivers/rtc/rtc-ds1374.c
> > > - watchdog part under drivers/watchdog/ds1374-wdt.c
> > > - mfd part drivers/mfd/ds1374.c
> > >
> > > The MFD part takes care of trickle charging and mode selection,
> > > since the usage modes of a) RTC + Alarm or b) RTC + WDT
> > > are mutually exclusive.
> > >
> > > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > > ---
> > > drivers/mfd/Kconfig | 10 +
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/ds1374.c | 260 ++++++++++++++++
> > > drivers/rtc/rtc-ds1374.c | 639 ++++++++++-----------------------------
> >
> > It looks like this should now depend on MFD_DS1374, right?
> >
> > > drivers/watchdog/Kconfig | 10 +
> > > drivers/watchdog/Makefile | 1 +
> > > drivers/watchdog/ds1374-wdt.c | 208 +++++++++++++
> >
> > The RTC and Watchdog drivers need to be split out of this patch and
> > placed into their own. Then we can take them through their respective
> > subsystem trees and do not have to rely on immutable branches for
> > unification.
>
> Ok, I haven't found a good way to keep this bisectable in that case. I'm
> open to suggestions. If the consensus ends up being to split it up, I'm
> more than happy to separate it out into multiple patches.
If it's genuinely not bisectable, then leave it as is.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-07-18 9:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 19:54 [PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Moritz Fischer
2017-07-13 19:54 ` [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device Moritz Fischer
2017-07-14 3:57 ` Guenter Roeck
2017-07-14 16:54 ` Moritz Fischer
2017-07-14 19:27 ` Guenter Roeck
2017-07-17 7:51 ` Lee Jones
2017-07-17 18:14 ` Moritz Fischer
2017-07-18 9:22 ` Lee Jones [this message]
2017-07-29 11:07 ` Alexandre Belloni
2017-07-29 22:26 ` Alexandre Belloni
2017-07-17 18:50 ` [PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Rob Herring
2017-07-18 9:27 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718092245.tc5oosbbb6lzvqpy@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox