From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Fabio Estevam <festevam@gmail.com>,
wim@iguana.be, linux-watchdog@vger.kernel.org,
wsa+renesas@sang-engineering.com, justinpopo6@gmail.com,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH 1/2] watchdog: renesas-wdt: Check the return value from clk_prepare_enable()
Date: Sat, 22 Jul 2017 14:24:22 -0700 [thread overview]
Message-ID: <20170722212422.GB2969@roeck-us.net> (raw)
In-Reply-To: <20170722203159.GA6399@tetsubishi>
On Sat, Jul 22, 2017 at 10:31:59PM +0200, Wolfram Sang wrote:
> On Sat, Jul 22, 2017 at 05:22:58PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> >
> > clk_prepare_enable() may fail, so we should better check its return value
> > and propagate it in the case of error.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>
> True. Yet, I have a patch in preparation which fully switches to
> RuntimePM which will make manual clk handling superfluous.
>
It won't need clk_prepare_enable() anymore ?
Guenter
next prev parent reply other threads:[~2017-07-22 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 20:22 [PATCH 1/2] watchdog: renesas-wdt: Check the return value from clk_prepare_enable() Fabio Estevam
2017-07-22 20:22 ` [PATCH 2/2] watchdog: bcm7038: " Fabio Estevam
2017-07-22 21:29 ` Guenter Roeck
2017-07-22 20:31 ` [PATCH 1/2] watchdog: renesas-wdt: " Wolfram Sang
2017-07-22 21:24 ` Guenter Roeck [this message]
2017-07-22 21:28 ` Wolfram Sang
2017-07-22 21:30 ` Guenter Roeck
2017-07-23 14:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170722212422.GB2969@roeck-us.net \
--to=linux@roeck-us.net \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=justinpopo6@gmail.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox