From: Guenter Roeck <linux@roeck-us.net>
To: Radu Rendec <rrendec@arista.com>
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 4/4] watchdog: i6300esb: bump version to 0.6
Date: Wed, 25 Oct 2017 13:57:51 -0700 [thread overview]
Message-ID: <20171025205751.GD30439@roeck-us.net> (raw)
In-Reply-To: <20171025153914.3467-4-rrendec@arista.com>
On Wed, Oct 25, 2017 at 04:39:14PM +0100, Radu Rendec wrote:
> The new version incorporates two major changes:
> * Watchdog subsystem support - allows the driver to coexist with other
> watchdog drivers; simplifies the code base
> * Multiple device support - supports multiple 6300ESB timer devices and
> and exposes them as separate watchdogs
>
Can you drop the version number instead ? It doesn't really serve a
useful purpose and ran out of favor upstream.
Thanks,
Guenter
> Signed-off-by: Radu Rendec <rrendec@arista.com>
> ---
> drivers/watchdog/i6300esb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/i6300esb.c b/drivers/watchdog/i6300esb.c
> index 3f7f66513dfa..fba81fa2f1c1 100644
> --- a/drivers/watchdog/i6300esb.c
> +++ b/drivers/watchdog/i6300esb.c
> @@ -45,7 +45,7 @@
> #include <linux/io.h>
>
> /* Module and version information */
> -#define ESB_VERSION "0.05"
> +#define ESB_VERSION "0.06"
> #define ESB_MODULE_NAME "i6300ESB timer"
>
> /* PCI configuration registers */
> --
> 2.13.6
>
next prev parent reply other threads:[~2017-10-25 20:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 18:25 [PATCH 1/3] watchdog: i6300esb: use the watchdog subsystem Radu Rendec
2017-10-16 18:25 ` [PATCH 2/3] watchdog: i6300esb: support multiple devices Radu Rendec
2017-10-22 17:05 ` [2/3] " Guenter Roeck
2017-10-16 18:25 ` [PATCH 3/3] watchdog: i6300esb: do not hardcode heartbeat limits Radu Rendec
2017-10-22 17:09 ` [3/3] " Guenter Roeck
2017-10-25 15:39 ` [PATCH v2 1/4] watchdog: i6300esb: use the watchdog subsystem Radu Rendec
2017-10-25 20:51 ` Guenter Roeck
2017-10-25 15:39 ` [PATCH v2 2/4] watchdog: i6300esb: support multiple devices Radu Rendec
2017-10-25 20:55 ` Guenter Roeck
2017-10-26 11:35 ` Radu Rendec
2017-10-26 13:51 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 1/4] watchdog: i6300esb: use the watchdog subsystem Radu Rendec
2017-10-27 1:03 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 2/4] watchdog: i6300esb: support multiple devices Radu Rendec
2017-10-27 1:02 ` Guenter Roeck
2017-10-27 1:04 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 3/4] watchdog: i6300esb: do not hardcode heartbeat limits Radu Rendec
2017-10-27 1:04 ` Guenter Roeck
2017-10-26 16:10 ` [PATCH v3 4/4] watchdog: i6300esb: remove info message and version number Radu Rendec
2017-10-27 1:05 ` Guenter Roeck
2017-10-27 10:58 ` Radu Rendec
2017-10-25 15:39 ` [PATCH v2 3/4] watchdog: i6300esb: do not hardcode heartbeat limits Radu Rendec
2017-10-25 20:56 ` Guenter Roeck
2017-10-25 15:39 ` [PATCH v2 4/4] watchdog: i6300esb: bump version to 0.6 Radu Rendec
2017-10-25 20:57 ` Guenter Roeck [this message]
2017-10-22 17:02 ` [1/3] watchdog: i6300esb: use the watchdog subsystem Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025205751.GD30439@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=rrendec@arista.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox