* [PATCH] watchdog: wdt_pci: mark expected switch fall-through
@ 2017-11-03 23:07 Gustavo A. R. Silva
2017-11-05 15:13 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-03 23:07 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/watchdog/wdt_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
index bc7addc..10e2cda0 100644
--- a/drivers/watchdog/wdt_pci.c
+++ b/drivers/watchdog/wdt_pci.c
@@ -430,7 +430,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,
if (wdtpci_set_heartbeat(new_heartbeat))
return -EINVAL;
wdtpci_ping();
- /* Fall */
+ /* fall through */
case WDIOC_GETTIMEOUT:
return put_user(heartbeat, p);
default:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: watchdog: wdt_pci: mark expected switch fall-through
2017-11-03 23:07 [PATCH] watchdog: wdt_pci: mark expected switch fall-through Gustavo A. R. Silva
@ 2017-11-05 15:13 ` Guenter Roeck
2017-11-06 0:43 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2017-11-05 15:13 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel
On Fri, Nov 03, 2017 at 06:07:23PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I replaced "Fall" with a proper
> "fall through" comment, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/wdt_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
> index bc7addc..10e2cda0 100644
> --- a/drivers/watchdog/wdt_pci.c
> +++ b/drivers/watchdog/wdt_pci.c
> @@ -430,7 +430,7 @@ static long wdtpci_ioctl(struct file *file, unsigned int cmd,
> if (wdtpci_set_heartbeat(new_heartbeat))
> return -EINVAL;
> wdtpci_ping();
> - /* Fall */
> + /* fall through */
> case WDIOC_GETTIMEOUT:
> return put_user(heartbeat, p);
> default:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: watchdog: wdt_pci: mark expected switch fall-through
2017-11-05 15:13 ` Guenter Roeck
@ 2017-11-06 0:43 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-06 0:43 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel
Quoting Guenter Roeck <linux@roeck-us.net>:
> On Fri, Nov 03, 2017 at 06:07:23PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case I replaced "Fall" with a proper
>> "fall through" comment, which is what GCC is expecting to find.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Thanks!
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-06 1:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-03 23:07 [PATCH] watchdog: wdt_pci: mark expected switch fall-through Gustavo A. R. Silva
2017-11-05 15:13 ` Guenter Roeck
2017-11-06 0:43 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox