From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:45630 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbdKEPjM (ORCPT ); Sun, 5 Nov 2017 10:39:12 -0500 Received: by mail-pf0-f194.google.com with SMTP id d28so5874249pfe.2 for ; Sun, 05 Nov 2017 07:39:11 -0800 (PST) Date: Sun, 5 Nov 2017 07:39:10 -0800 From: Guenter Roeck To: Radu Rendec Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [2/2] watchdog: xen_wdt: remove info message and version number Message-ID: <20171105153910.GA28756@roeck-us.net> References: <20171103153153.9992-3-rrendec@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103153153.9992-3-rrendec@arista.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Fri, Nov 03, 2017 at 03:31:53PM +0000, Radu Rendec wrote: > The initial info message (early in the xen_wdt_init_module() function) > is not very useful and we already have a message on successful probe. If > the probe fails, additional messages are printed anyway. > > The version number serves no useful purpose and it ran out of favor > upstream anyway. > > Signed-off-by: Radu Rendec > --- > drivers/watchdog/xen_wdt.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/watchdog/xen_wdt.c b/drivers/watchdog/xen_wdt.c > index 8bea946dfdc7..e1aeff0ea6eb 100644 > --- a/drivers/watchdog/xen_wdt.c > +++ b/drivers/watchdog/xen_wdt.c > @@ -12,7 +12,6 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #define DRV_NAME "wdt" > -#define DRV_VERSION "0.01" > > #include > #include > @@ -203,8 +202,6 @@ static int __init xen_wdt_init_module(void) > if (!xen_domain()) > return -ENODEV; > > - pr_info("Xen WatchDog Timer Driver v%s\n", DRV_VERSION); > - > err = platform_driver_register(&xen_wdt_driver); > if (err) > return err; > @@ -231,5 +228,4 @@ module_exit(xen_wdt_cleanup_module); > As I mentioned in the other patch, any chance to use module_platform_driver_probe() ? The if (!xen_domain()) return -ENODEV; could be moved there. Thanks, Guenter > MODULE_AUTHOR("Jan Beulich "); > MODULE_DESCRIPTION("Xen WatchDog Timer Driver"); > -MODULE_VERSION(DRV_VERSION); > MODULE_LICENSE("GPL");