From: Guenter Roeck <linux@roeck-us.net>
To: Jerry Hoemann <jerry.hoemann@hpe.com>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, rwright@hpe.com,
maurice.a.saldivar@hpe.com
Subject: Re: [PATCH v2 05/11] watchdog/hpwdt: Update Module info.
Date: Tue, 13 Feb 2018 09:49:50 -0800 [thread overview]
Message-ID: <20180213174950.GC22401@roeck-us.net> (raw)
In-Reply-To: <20180212052111.12010-6-jerry.hoemann@hpe.com>
On Sun, Feb 11, 2018 at 10:21:05PM -0700, Jerry Hoemann wrote:
> Update Module Author and permission on parameters so that the
> parameters show up in sysfs.
>
Does it really add value to see the module parameters in sysfs ?
You would get both in standardized form by enabling WATCHDOG_SYSFS.
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
> drivers/watchdog/hpwdt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index ee9a92220ece..dead59f9ca80 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -432,20 +432,20 @@ static struct pci_driver hpwdt_driver = {
> .remove = hpwdt_exit,
> };
>
> -MODULE_AUTHOR("Tom Mingarelli");
> -MODULE_DESCRIPTION("hp watchdog driver");
> +MODULE_AUTHOR("Jerry Hoemann");
> +MODULE_DESCRIPTION("hpe watchdog driver");
> MODULE_LICENSE("GPL");
> MODULE_VERSION(HPWDT_VERSION);
>
> -module_param(soft_margin, int, 0);
> +module_param(soft_margin, int, 0444);
> MODULE_PARM_DESC(soft_margin, "Watchdog timeout in seconds");
>
> -module_param(nowayout, bool, 0);
> +module_param(nowayout, bool, 0444);
> MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
> __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>
> #ifdef CONFIG_HPWDT_NMI_DECODING /* { */
> -module_param(allow_kdump, int, 0);
> +module_param(allow_kdump, int, 0444);
> MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs");
> #endif /* } */
>
> --
> 2.13.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-13 17:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 5:21 [PATCH v2 00/11] watchdog/hpwdt: Update driver to use watchdog core Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 01/11] watchdog/hpwdt: Remove legacy NMI sourcing Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 02/11] watchdog/hpwdt: remove include files no longer needed Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 03/11] watchdog/hpwdt: Update nmi_panic message Jerry Hoemann
2018-02-13 17:41 ` Guenter Roeck
2018-02-13 21:59 ` Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 04/11] watchdog/hpwdt: white space changes Jerry Hoemann
2018-02-12 9:35 ` Philippe Ombredanne
2018-02-13 17:44 ` Guenter Roeck
2018-02-12 5:21 ` [PATCH v2 05/11] watchdog/hpwdt: Update Module info Jerry Hoemann
2018-02-13 17:49 ` Guenter Roeck [this message]
2018-02-14 0:01 ` Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 06/11] watchdog/hpwdt: Modify to use watchdog core Jerry Hoemann
2018-02-12 9:06 ` Marcus Folkesson
2018-02-13 18:05 ` Guenter Roeck
2018-02-13 21:36 ` Jerry Hoemann
2018-02-13 21:55 ` Guenter Roeck
2018-02-13 23:54 ` Jerry Hoemann
2018-02-14 20:53 ` Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 07/11] watchdog/hpwdt: Select WATCHDOG_CORE Jerry Hoemann
2018-02-13 18:04 ` Guenter Roeck
2018-02-12 5:21 ` [PATCH v2 08/11] watchdog/hpwdt: Programable Pretimeout NMI Jerry Hoemann
2018-02-12 9:09 ` Marcus Folkesson
2018-02-12 5:21 ` [PATCH v2 09/11] watchdog/hpwdt: condition early return of NMI handler on iLO5 Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 10/11] watchdog/hpwdt: remove allow_kdump module parameter Jerry Hoemann
2018-02-13 18:20 ` Guenter Roeck
2018-02-13 23:10 ` Jerry Hoemann
2018-02-12 5:21 ` [PATCH v2 11/11] watchdog/hpwdt: Update driver version Jerry Hoemann
2018-02-13 17:07 ` Guenter Roeck
2018-02-14 0:21 ` Jerry Hoemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213174950.GC22401@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=maurice.a.saldivar@hpe.com \
--cc=rwright@hpe.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).