[PATCH 0/1] xen_wdt: fix build failure

[PATCH 0/1] xen_wdt: fix build failure

[Radu Rendec]

Hi Guenter,

I just saw Matteo Croce's email/patch on the i6300esb build failure and
I realized that xen_wdt has the exact same problem. I forgot to add a
dependency on CONFIG_WATCHDOG_CORE for both drivers when I ported them
to use the watchdog core.

This patch is the xen_wdt equivalent of Matteo Croce's patch for
i6300esb.

Thanks!

Radu Rendec (1):
  watchdog: xen_wdt: fix potential build failure

 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.13.6

[PATCH 1/1] watchdog: xen_wdt: fix potential build failure

[Radu Rendec]

xen_wdt uses watchdog core functions (from watchdog_core.c) and, when
compiled without CONFIG_WATCHDOG_CORE being set, it produces the
following build error:

ERROR: "devm_watchdog_register_device" [drivers/watchdog/xen_wdt.ko] undefined!
ERROR: "watchdog_init_timeout" [drivers/watchdog/xen_wdt.ko] undefined!

Fix this by selecting CONFIG_WATCHDOG_CORE when CONFIG_XEN_WDT is set.

Fixes: 18cffd68e0c4 ("watchdog: xen_wdt: use the watchdog subsystem")
Signed-off-by: Radu Rendec <radu.rendec@gmail.com>
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index a16bad78679b..2953e9fbb818 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1838,6 +1838,7 @@ config WATCHDOG_SUN4V
 config XEN_WDT
 	tristate "Xen Watchdog support"
 	depends on XEN
+	select WATCHDOG_CORE
 	help
 	  Say Y here to support the hypervisor watchdog capability provided
 	  by Xen 4.0 and newer.  The watchdog timeout period is normally one
-- 
2.13.6

Re: [PATCH 1/1] watchdog: xen_wdt: fix potential build failure

[Guenter Roeck]

On 02/19/2018 06:38 AM, Radu Rendec wrote:
> xen_wdt uses watchdog core functions (from watchdog_core.c) and, when
> compiled without CONFIG_WATCHDOG_CORE being set, it produces the
> following build error:
> 
> ERROR: "devm_watchdog_register_device" [drivers/watchdog/xen_wdt.ko] undefined!
> ERROR: "watchdog_init_timeout" [drivers/watchdog/xen_wdt.ko] undefined!
> 
> Fix this by selecting CONFIG_WATCHDOG_CORE when CONFIG_XEN_WDT is set.
> 
> Fixes: 18cffd68e0c4 ("watchdog: xen_wdt: use the watchdog subsystem")
> Signed-off-by: Radu Rendec <radu.rendec@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Sorry, should have caught that during the review.

Guenter

> ---
>   drivers/watchdog/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index a16bad78679b..2953e9fbb818 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1838,6 +1838,7 @@ config WATCHDOG_SUN4V
>   config XEN_WDT
>   	tristate "Xen Watchdog support"
>   	depends on XEN
> +	select WATCHDOG_CORE
>   	help
>   	  Say Y here to support the hypervisor watchdog capability provided
>   	  by Xen 4.0 and newer.  The watchdog timeout period is normally one
>