From: Guenter Roeck <linux@roeck-us.net>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Rob Herring <robh@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Mark Rutland <mark.rutland@arm.com>,
Frank Rowand <frowand.list@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v4 1/6] Documentation: DT: Consolidate SP805 binding docs
Date: Wed, 27 Jun 2018 11:42:34 -0700 [thread overview]
Message-ID: <20180627184234.GA19538@roeck-us.net> (raw)
In-Reply-To: <a18733e2-be06-4ea9-dbfb-1d4f756a97e7@broadcom.com>
On Wed, Jun 27, 2018 at 11:38:48AM -0700, Ray Jui wrote:
>
>
> On 6/27/2018 11:33 AM, Guenter Roeck wrote:
> >On Wed, Jun 20, 2018 at 10:39:16AM -0700, Ray Jui wrote:
> >>Hi Guenter/Rob,
> >>
> >>Kindly let me know how you want to proceed with this?
> >>
> >
> >If I recall correctly, the patch series does not add a new problem
> >but merely exposes one. Is my recollection correct ? If so, maybe
> >we should just add a note somewhere indicating what might be wrong
> >and otherwise apply the series.
> >
> >Does this make sense ?
>
> Yes this makes a lot of sense to me. This patch series exposes potential
> problems in some SoCs that they might not be feeding the correct clock into
> WDT, at least based on clock names from their DT entries.
>
> This patch series does not change/affect how SP805 works on those systems.
>
> Where should the note be added?
>
I would suggest to add a note into the driver where the clock is used,
with the details discussed here.
Does this make sense ?
Thanks,
Guenter
next prev parent reply other threads:[~2018-06-27 18:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 18:01 [PATCH v4 0/6] Enhance support for the SP805 WDT Ray Jui
2018-05-28 18:01 ` [PATCH v4 1/6] Documentation: DT: Consolidate SP805 binding docs Ray Jui
2018-06-05 19:41 ` Rob Herring
2018-06-06 16:19 ` Guenter Roeck
2018-06-06 16:33 ` Rob Herring
2018-06-06 23:39 ` Ray Jui
2018-06-20 17:39 ` Ray Jui
2018-06-27 18:33 ` Guenter Roeck
2018-06-27 18:38 ` Ray Jui
2018-06-27 18:42 ` Guenter Roeck [this message]
2018-06-27 18:47 ` Ray Jui
2018-06-27 18:55 ` Guenter Roeck
2018-06-28 23:50 ` Ray Jui
2018-06-29 3:00 ` Guenter Roeck
2018-06-29 2:55 ` [v4,1/6] " Guenter Roeck
2018-05-28 18:01 ` [PATCH v4 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 Ray Jui
2018-06-05 19:55 ` Rob Herring
2018-06-29 2:55 ` [v4, " Guenter Roeck
2018-05-28 18:01 ` [PATCH v4 3/6] watchdog: sp805: add 'timeout-sec' DT property support Ray Jui
2018-05-28 18:01 ` [PATCH v4 4/6] watchdog: sp805: set WDOG_HW_RUNNING when appropriate Ray Jui
2018-05-28 18:01 ` [PATCH v4 5/6] arm64: dt: set initial SR watchdog timeout to 60 seconds Ray Jui
2018-07-09 17:40 ` Florian Fainelli
2018-05-28 18:01 ` [PATCH v4 6/6] arm64: defconfig: add CONFIG_ARM_SP805_WATCHDOG Ray Jui
2018-07-09 17:40 ` Florian Fainelli
2018-06-06 19:29 ` [PATCH v4 0/6] Enhance support for the SP805 WDT Florian Fainelli
2018-06-06 23:40 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627184234.GA19538@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ray.jui@broadcom.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).