From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-watchdog@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: [RFC PATCH v2 1/4] watchdog: core: add mechanism to prevent removing if NOWAYOUT
Date: Tue, 28 Aug 2018 21:14:13 +0200 [thread overview]
Message-ID: <20180828191416.7781-2-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20180828191416.7781-1-wsa+renesas@sang-engineering.com>
To prevent removing if NOWAYOUT, we invalidate the .remove function and
suppress the bind/unbind attributes in sysfs. These are driver
capabilities, so we need to set it up at runtime during init. To avoid
boilerplate, introduce module_watchdog_driver() similar to
module_driver(). On top of that, we then build
module_watchdog_platform_driver(). Others may follow, if needed.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
include/linux/watchdog.h | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
index 44985c4a1e86..5768fb6b5cde 100644
--- a/include/linux/watchdog.h
+++ b/include/linux/watchdog.h
@@ -216,4 +216,24 @@ extern void watchdog_unregister_device(struct watchdog_device *);
/* devres register variant */
int devm_watchdog_register_device(struct device *dev, struct watchdog_device *);
+#define module_watchdog_driver(__driver, __register, __unregister, __nowayout, ...) \
+static int __init __driver##_init(void) \
+{ \
+ if (__nowayout) { \
+ __driver.driver.suppress_bind_attrs = true; \
+ __driver.remove = NULL; \
+ } \
+ return __register(&(__driver) ##__VA_ARGS__); \
+} \
+module_init(__driver##_init); \
+static void __exit __driver##_exit(void) \
+{ \
+ __unregister(&(__driver), ##__VA_ARGS__); \
+} \
+module_exit(__driver##_exit)
+
+#define module_watchdog_platform_driver(__platform_driver, __nowayout) \
+ module_watchdog_driver(__platform_driver, platform_driver_register, \
+ platform_driver_unregister, __nowayout)
+
#endif /* ifndef _LINUX_WATCHDOG_H */
--
2.11.0
next prev parent reply other threads:[~2018-08-28 23:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 19:14 [RFC PATCH v2 0/4] watchdog: prevent removing a driver if NOWAYOUT Wolfram Sang
2018-08-28 19:14 ` Wolfram Sang [this message]
2018-08-28 19:33 ` [RFC PATCH v2 1/4] watchdog: core: add mechanism to prevent removing " Guenter Roeck
2018-08-28 20:07 ` Wolfram Sang
2018-08-28 20:47 ` Guenter Roeck
2018-08-28 19:14 ` [RFC PATCH v2 2/4] watchdog: renesas_wdt: avoid " Wolfram Sang
2018-08-28 19:14 ` [RFC PATCH v2 3/4] watchdog: core: add module_watchdog_pci_driver() Wolfram Sang
2018-08-28 19:14 ` [RFC PATCH v2 4/4] watchdog: i6300esb: avoid removing if NOWAYOUT Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828191416.7781-2-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).