From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-watchdog@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: [RFC PATCH v3 0/4] watchdog: prevent removing a driver if NOWAYOUT
Date: Wed, 29 Aug 2018 09:42:37 +0200 [thread overview]
Message-ID: <20180829074241.1943-1-wsa+renesas@sang-engineering.com> (raw)
So, here is my second approach, now avoiding probe() and targetting the init
call. To avoid boilerplate, I introduced macros similar to module_driver(). It
still feels a little adventurous because of hard-coding
'.driver.suppress_bind_attts' in the macro and trusting various driver types
(like platform and PCI) to follow this structure.
Having all this said, it works nicely on my Renesas Salvator-XS (R-Car M3-N).
build bot is happy. A git branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/wdt-suppress-attr
Looking forward to comments.
Thanks,
Wolfram
Changes since V2:
* keep the remove callback valid
* remove 'if' from macro
Wolfram Sang (4):
watchdog: core: add mechanism to prevent removing if NOWAYOUT
watchdog: renesas_wdt: avoid removing if NOWAYOUT
watchdog: core: add module_watchdog_pci_driver()
watchdog: i6300esb: avoid removing if NOWAYOUT
drivers/watchdog/i6300esb.c | 2 +-
drivers/watchdog/renesas_wdt.c | 2 +-
include/linux/watchdog.h | 21 +++++++++++++++++++++
3 files changed, 23 insertions(+), 2 deletions(-)
--
2.11.0
next reply other threads:[~2018-08-29 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:42 Wolfram Sang [this message]
2018-08-29 7:42 ` [RFC PATCH v3 1/4] watchdog: core: add mechanism to prevent removing if NOWAYOUT Wolfram Sang
2018-08-29 16:14 ` Guenter Roeck
2018-08-29 20:55 ` Jerry Hoemann
2018-09-05 13:54 ` Geert Uytterhoeven
2018-09-05 15:33 ` Wolfram Sang
2018-08-29 7:42 ` [RFC PATCH v3 2/4] watchdog: renesas_wdt: avoid " Wolfram Sang
2018-08-29 7:42 ` [RFC PATCH v3 3/4] watchdog: core: add module_watchdog_pci_driver() Wolfram Sang
2018-08-29 7:42 ` [RFC PATCH v3 4/4] watchdog: i6300esb: avoid removing if NOWAYOUT Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829074241.1943-1-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).