From: Guenter Roeck <linux@roeck-us.net>
To: Jagdish Tirumala <t.jag587@gmail.com>
Cc: wim@linux-watchdog.org, yamada.masahiro@socionext.com,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: diag288_wdt: pointer location foo * bar should be foo *bar
Date: Wed, 12 Sep 2018 14:18:22 -0700 [thread overview]
Message-ID: <20180912211822.GA12970@roeck-us.net> (raw)
In-Reply-To: <20180912172907.1802-1-t.jag587@gmail.com>
On Wed, Sep 12, 2018 at 10:29:07AM -0700, Jagdish Tirumala wrote:
> Fix the following checkpatch error:
>
> ERROR: pointer location foo * bar should be foo *bar
> FILE: drivers/watchdog/diag288_wdt.c:202
>
> Signed-off-by: Jagdish Tirumala <t.jag587@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/diag288_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/diag288_wdt.c b/drivers/watchdog/diag288_wdt.c
> index 806a04a676b7..046333d1beb2 100644
> --- a/drivers/watchdog/diag288_wdt.c
> +++ b/drivers/watchdog/diag288_wdt.c
> @@ -199,7 +199,7 @@ static int wdt_ping(struct watchdog_device *dev)
> return ret;
> }
>
> -static int wdt_set_timeout(struct watchdog_device * dev, unsigned int new_to)
> +static int wdt_set_timeout(struct watchdog_device *dev, unsigned int new_to)
> {
> dev->timeout = new_to;
> return wdt_ping(dev);
> --
> 2.17.1
>
prev parent reply other threads:[~2018-09-13 2:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 17:29 [PATCH] watchdog: diag288_wdt: pointer location foo * bar should be foo *bar Jagdish Tirumala
2018-09-12 21:18 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912211822.GA12970@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=t.jag587@gmail.com \
--cc=wim@linux-watchdog.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).