Re: [RFC PATCH v1 07/13] devicetree: bindings: Document first ROHM BD70528 bindings

Matti Vaittinen
2019-02-28T06:49:40Z

Hello Rob, All

Sorry for long delay - I was ill for a few days. Back at the business
now =)

Rob, maybe dropping the RFC tag has messed your book keeping? This
is the latest version:
https://lore.kernel.org/lkml/90c3b820baf072a7cc3a21aa50c661774a045158.1550148989.git.matti.vaittinen@fi.rohmeurope.com/
and I thought it already had the Reviewed-by tag from you :)

On Fri, Feb 22, 2019 at 06:30:41PM -0600, Rob Herring wrote:
> On Tue, Jan 22, 2019 at 11:45:38AM +0200, Matti Vaittinen wrote:
> > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> > drivers) and 4 GPIO pins which can be configured for I/O or
> > as interrupt sources withe configurable trigger levels.
>
> 'dt-bindings: mfd: ...' for the subject.

I see at least the patch subject comment is still valid though. Do you
want me to change it and resubmit the series?

>
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 104 +++++++++++++++++++++
> > 1 file changed, 104 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > new file mode 100644
> > index 000000000000..21801440a53a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > @@ -0,0 +1,104 @@
> > +* ROHM BD70528 Power Management Integrated Circuit bindings
> > +
> > +BD70528MWV is an ultra-low Iq general purpose single-chip power management IC
> > +for battery-powered portable devices. The IC integrates 3 ultra-low current
> > +consumption buck converters, 3 LDOs and 2 LED Drivers. Also included are 4
> > +GPIOs, a real-time clock (RTC), a 32kHz clock gate, high-accuracy VREF
> > +for use with an external ADC, flexible dual-input power path, 10 bits SAR ADC
> > +for battery temperature monitor and 1S battery charger with scalable charge
> > +currents.

Br,
Matti Vaittinen

--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~