From: Guenter Roeck <linux@roeck-us.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through
Date: Tue, 26 Feb 2019 09:55:19 -0800 [thread overview]
Message-ID: <20190226175519.GA26692@roeck-us.net> (raw)
In-Reply-To: <ceb0ac6a-df12-4e01-167a-39e306723dde@embeddedor.com>
On Tue, Feb 26, 2019 at 11:46:09AM -0600, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
Wim, presumably.
Guenter
> Thanks
> --
> Gustavo
>
>
> On 2/18/19 11:50 AM, Gustavo A. R. Silva wrote:
> >
> >
> > On 2/18/19 10:09 AM, Guenter Roeck wrote:
> >> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >>> cases where we are expecting to fall through.
> >>>
> >>> This patch fixes the following warning:
> >>>
> >>> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
> >>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >>> pc87413_refresh();
> >>> ^~~~~~~~~~~~~~~~~
> >>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
> >>> case WDIOC_GETTIMEOUT:
> >>> ^~~~
> >>>
> >>> Warning level 3 was used: -Wimplicit-fallthrough=3
> >>>
> >>> Notice that, in this particular case, the code comment is modified
> >>> in accordance with what GCC is expecting to find.
> >>>
> >>> This patch is part of the ongoing efforts to enable
> >>> -Wimplicit-fallthrough.
> >>>
> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >>
> >
> > Thanks, Guenter.
> >
> > --
> > Gustavo
> >
next prev parent reply other threads:[~2019-02-26 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 20:26 [PATCH] watchdog: pc87413: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-18 16:09 ` Guenter Roeck
2019-02-18 17:50 ` Gustavo A. R. Silva
2019-02-26 17:46 ` Gustavo A. R. Silva
2019-02-26 17:55 ` Guenter Roeck [this message]
2019-02-26 18:10 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226175519.GA26692@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox