From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-watchdog@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH] watchdog: renesas_wdt: drop superfluous glob pattern
Date: Sun, 14 Apr 2019 07:15:06 -0700 [thread overview]
Message-ID: <20190414141506.GA20689@roeck-us.net> (raw)
In-Reply-To: <20190414100306.1221-1-wsa+renesas@sang-engineering.com>
On Sun, Apr 14, 2019 at 12:03:06PM +0200, Wolfram Sang wrote:
> If we want to match all revisions, it is enough to leave the field
> empty.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Only build tested, no HW. Found by code review.
>
> drivers/watchdog/renesas_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> index 94cd8830ba9a..565dbc1ec638 100644
> --- a/drivers/watchdog/renesas_wdt.c
> +++ b/drivers/watchdog/renesas_wdt.c
> @@ -151,7 +151,6 @@ static const struct soc_device_attribute rwdt_quirks_match[] = {
> .data = (void *)1, /* needs single CPU */
> }, {
> .soc_id = "r8a7792",
> - .revision = "*",
> .data = (void *)0, /* needs SMP disabled */
> },
> { /* sentinel */ }
> --
> 2.11.0
>
prev parent reply other threads:[~2019-04-14 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 10:03 [PATCH] watchdog: renesas_wdt: drop superfluous glob pattern Wolfram Sang
2019-04-14 14:15 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190414141506.GA20689@roeck-us.net \
--to=linux@roeck-us.net \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox