Re: [PATCH 1/7] clk: samsung: s3c64xx: Declare s3c64xx_clk_init() in shared header

Tomasz Figa
2020-07-29T17:40:02Z

2020年7月29日(水) 18:11 Krzysztof Kozlowski <krzk@kernel.org>:
>
> The s3c64xx_clk_init() is defined and used by clk-s3c64xx driver and
> also used in mach-s3c64xx machine code. Move the declaration to a
> header to fix W=1 build warning:
>
> drivers/clk/samsung/clk-s3c64xx.c:391:13: warning: no previous prototype for 's3c64xx_clk_init' [-Wmissing-prototypes]
> 391 | void __init s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f,
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> MAINTAINERS | 1 +
> arch/arm/mach-s3c64xx/common.c | 1 +
> arch/arm/mach-s3c64xx/common.h | 2 --
> drivers/clk/samsung/clk-s3c64xx.c | 1 +
> include/linux/clk/samsung.h | 21 +++++++++++++++++++++
> 5 files changed, 24 insertions(+), 2 deletions(-)
> create mode 100644 include/linux/clk/samsung.h
>

Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz