Re: [PATCH v6 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller

Lee Jones
2021-01-19T08:24:47Z

On Tue, 19 Jan 2021, AceLan Kao wrote:

> Campion Kang <campion.kang@advantech.com.tw> 於 2021年1月18日 週一 下午8:37寫道：
> >
> > AHC1EC0 is the embedded controller driver for Advantech industrial
> > products. This provides sub-devices such as hwmon and watchdog, and also
> > expose functions for sub-devices to read/write the value to embedded
> > controller.
> >
> > Changed since V5:
> > - Kconfig: add "AHC1EC0" string to clearly define the EC name
> > - fix the code according to reviewer's suggestion
> > - remove unnecessary header files
> > - change the structure name to lower case, align with others
> > naming
> >
> > Signed-off-by: Campion Kang <campion.kang@advantech.com.tw>
> > ---
> > drivers/mfd/Kconfig | 10 +
> > drivers/mfd/Makefile | 2 +
> > drivers/mfd/ahc1ec0.c | 808 ++++++++++++++++++++++++++++++++++++
> > include/linux/mfd/ahc1ec0.h | 276 ++++++++++++
> > 4 files changed, 1096 insertions(+)
> > create mode 100644 drivers/mfd/ahc1ec0.c
> > create mode 100644 include/linux/mfd/ahc1ec0.h

[...]

NB: Snipped 1000 lines.

> Tested-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>

Would you be kind enough to snip your replies please AceLan?

It would have the benefit of saving a lot of people a little time.

TIA.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog