From: Guenter Roeck <linux@roeck-us.net>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: mlx-wdt: Use regmap_write_bits()
Date: Tue, 7 Sep 2021 05:40:18 -0700 [thread overview]
Message-ID: <20210907124018.GD4989@roeck-us.net> (raw)
In-Reply-To: <20210907092732.31815-1-p.zabel@pengutronix.de>
On Tue, Sep 07, 2021 at 11:27:32AM +0200, Philipp Zabel wrote:
> Use the regmap_write_bits() macro instead of regmap_update_bits_base().
> No functional change.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mlx_wdt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/mlx_wdt.c b/drivers/watchdog/mlx_wdt.c
> index 54193369e85c..9c5b6616fc87 100644
> --- a/drivers/watchdog/mlx_wdt.c
> +++ b/drivers/watchdog/mlx_wdt.c
> @@ -100,9 +100,8 @@ static int mlxreg_wdt_ping(struct watchdog_device *wdd)
> struct mlxreg_wdt *wdt = watchdog_get_drvdata(wdd);
> struct mlxreg_core_data *reg_data = &wdt->pdata->data[wdt->ping_idx];
>
> - return regmap_update_bits_base(wdt->regmap, reg_data->reg,
> - ~reg_data->mask, BIT(reg_data->bit),
> - NULL, false, true);
> + return regmap_write_bits(wdt->regmap, reg_data->reg, ~reg_data->mask,
> + BIT(reg_data->bit));
> }
>
> static int mlxreg_wdt_set_timeout(struct watchdog_device *wdd,
> --
> 2.30.2
>
prev parent reply other threads:[~2021-09-07 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 9:27 [PATCH] watchdog: mlx-wdt: Use regmap_write_bits() Philipp Zabel
2021-09-07 12:40 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907124018.GD4989@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox