* [PATCH] watchdog: mtk_wdt: use platform_get_irq_optional
@ 2021-12-08 9:55 Tzung-Bi Shih
2021-12-08 15:44 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Tzung-Bi Shih @ 2021-12-08 9:55 UTC (permalink / raw)
To: wim, linux, matthias.bgg
Cc: linux-watchdog, linux-arm-kernel, linux-mediatek, wangqing,
tzungbi
The watchdog pre-timeout (bark) interrupt is optional. Use
platform_get_irq_optional() to avoid seeing such following
error message:
>>> mtk-wdt 10007000.watchdog: IRQ index 0 not found
Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
---
The patch bases on linux-next next-20211208.
drivers/watchdog/mtk_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index 543cf38bd04e..4577a76dd464 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -339,7 +339,7 @@ static int mtk_wdt_probe(struct platform_device *pdev)
if (IS_ERR(mtk_wdt->wdt_base))
return PTR_ERR(mtk_wdt->wdt_base);
- irq = platform_get_irq(pdev, 0);
+ irq = platform_get_irq_optional(pdev, 0);
if (irq > 0) {
err = devm_request_irq(&pdev->dev, irq, mtk_wdt_isr, 0, "wdt_bark",
&mtk_wdt->wdt_dev);
--
2.34.1.173.g76aa8bc2d0-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: mtk_wdt: use platform_get_irq_optional
2021-12-08 9:55 [PATCH] watchdog: mtk_wdt: use platform_get_irq_optional Tzung-Bi Shih
@ 2021-12-08 15:44 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-12-08 15:44 UTC (permalink / raw)
To: Tzung-Bi Shih
Cc: wim, matthias.bgg, linux-watchdog, linux-arm-kernel,
linux-mediatek, wangqing
On Wed, Dec 08, 2021 at 05:55:55PM +0800, Tzung-Bi Shih wrote:
> The watchdog pre-timeout (bark) interrupt is optional. Use
> platform_get_irq_optional() to avoid seeing such following
> error message:
> >>> mtk-wdt 10007000.watchdog: IRQ index 0 not found
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> The patch bases on linux-next next-20211208.
>
> drivers/watchdog/mtk_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index 543cf38bd04e..4577a76dd464 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -339,7 +339,7 @@ static int mtk_wdt_probe(struct platform_device *pdev)
> if (IS_ERR(mtk_wdt->wdt_base))
> return PTR_ERR(mtk_wdt->wdt_base);
>
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq > 0) {
> err = devm_request_irq(&pdev->dev, irq, mtk_wdt_isr, 0, "wdt_bark",
> &mtk_wdt->wdt_dev);
> --
> 2.34.1.173.g76aa8bc2d0-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-08 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-08 9:55 [PATCH] watchdog: mtk_wdt: use platform_get_irq_optional Tzung-Bi Shih
2021-12-08 15:44 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).