From: Scott Cheloha <cheloha@linux.ibm.com>
To: linux-watchdog@vger.kernel.org
Cc: linux@roeck-us.net, tzungbi@kernel.org, brking@linux.ibm.com,
nathanl@linux.ibm.com, aik@ozlabs.ru, npiggin@gmail.com,
vaishnavi@linux.ibm.com, wvoigt@us.ibm.com
Subject: [RFC v2 0/2] Add driver for PAPR watchdog timers
Date: Mon, 9 May 2022 12:43:55 -0500 [thread overview]
Message-ID: <20220509174357.5448-1-cheloha@linux.ibm.com> (raw)
This second RFC incorporates feedback from the previous RFC:
https://lore.kernel.org/linux-watchdog/20220413165104.179144-1-cheloha@linux.ibm.com/
v2 changes of note:
- Add a firmware feature flag for the H_WATCHDOG feature,
FW_FEATURE_WATCHDOG.
- Register a platform_device for the first watchdog timer during a
pseries initcall if we have FW_FEATURE_WATCHDOG. Use id zero, as
there could be more than one timer in the future.
- Alphabetize Makefile changes.
- Add missing copyright information to pseries-wdt.c.
- Add an 'action' module parameter that configures how the guest is
terminated on watchdog expiration.
- Use dev_*() for logging critical errors instead of pr_*().
- Handle the H_NOOP case when trying to stop the watchdog. If the
given watchdog is not actually running, H_WATCHDOG returns H_NOOP.
This is harmless, so we should treat it as a success.
- We don't need pseries_wdt_remove() at all.
- Check watchdog_active() before stopping/starting the timer across
suspend/resume.
- Consolidate all code from pseries_wdt_module_init() into
pseries_wdt_probe(). We can then use module_platform_driver().
I have one lingering question:
- The pseries-wdt module is not "automatically" loaded during boot.
When I do
# modprobe pseries-wdt
the driver attaches to the platform bus as expected and the
/dev/watchdog* devices for the pseries-wdt.0 platform device
are created.
I was under the impression that driver/device matching for
the platform bus was simple string comparison.
... what am I doing wrong? Is this expected behavior? Do
I need to do additional configuration to get the module to
load automatically at boot time?
next reply other threads:[~2022-05-09 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 17:43 Scott Cheloha [this message]
2022-05-09 17:43 ` [RFC v2 1/2] powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return code Scott Cheloha
2022-05-09 17:43 ` [RFC v2 2/2] watchdog: pseries-wdt: initial support for PAPR virtual watchdog timers Scott Cheloha
2022-05-10 2:35 ` Tzung-Bi Shih
2022-05-10 3:34 ` Guenter Roeck
2022-05-11 5:08 ` Alexey Kardashevskiy
2022-05-11 5:27 ` Guenter Roeck
2022-05-10 15:48 ` Scott Cheloha
2022-05-10 16:04 ` Guenter Roeck
2022-05-10 16:15 ` Scott Cheloha
2022-05-10 19:00 ` Guenter Roeck
2022-05-11 5:38 ` [RFC v2 0/2] Add driver for PAPR " Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509174357.5448-1-cheloha@linux.ibm.com \
--to=cheloha@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=brking@linux.ibm.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=tzungbi@kernel.org \
--cc=vaishnavi@linux.ibm.com \
--cc=wvoigt@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox