From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: "Angel Iglesias" <ang.iglesiasg@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Grant Likely" <grant.likely@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
linux-i2c@vger.kernel.org, kernel@pengutronix.de,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's .probe_new()
Date: Tue, 31 Jan 2023 09:01:41 -0800 [thread overview]
Message-ID: <20230131170141.GA3598528@roeck-us.net> (raw)
In-Reply-To: <20221118224540.619276-597-uwe@kleine-koenig.org>
On Fri, Nov 18, 2022 at 11:45:30PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/ziirave_wdt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index d0e88875443a..21ca08a694ee 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -593,8 +593,7 @@ static int ziirave_wdt_init_duration(struct i2c_client *client)
> reset_duration);
> }
>
> -static int ziirave_wdt_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ziirave_wdt_probe(struct i2c_client *client)
> {
> int ret;
> struct ziirave_wdt_data *w_priv;
> @@ -732,7 +731,7 @@ static struct i2c_driver ziirave_wdt_driver = {
> .name = "ziirave_wdt",
> .of_match_table = zrv_wdt_of_match,
> },
> - .probe = ziirave_wdt_probe,
> + .probe_new = ziirave_wdt_probe,
> .remove = ziirave_wdt_remove,
> .id_table = ziirave_wdt_id,
> };
next prev parent reply other threads:[~2023-01-31 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's .probe_new() Uwe Kleine-König
2022-11-18 22:57 ` Guenter Roeck
2023-01-27 10:32 ` Uwe Kleine-König
2023-02-11 23:01 ` Uwe Kleine-König
2023-02-12 0:11 ` Guenter Roeck
2023-01-31 17:01 ` Guenter Roeck [this message]
2022-11-19 6:50 ` [PATCH 000/606] i2c: Complete conversion to i2c_probe_new patchwork-bot+chrome-platform
2022-11-19 6:50 ` patchwork-bot+chrome-platform
2022-11-19 11:10 ` Wolfram Sang
2022-11-20 19:43 ` Sebastian Reichel
2022-11-21 9:53 ` Lee Jones
2022-11-22 18:58 ` Jonathan Cameron
2022-11-22 20:16 ` Uwe Kleine-König
2022-11-26 15:43 ` Andy Shevchenko
2022-12-09 12:00 ` (subset) " Robert Foss
2022-12-12 16:36 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131170141.GA3598528@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ang.iglesiasg@gmail.com \
--cc=grant.likely@linaro.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=uwe@kleine-koenig.org \
--cc=wim@linux-watchdog.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox