Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	matthias.bgg@gmail.com, arinc.unal@arinc9.com,
	tsbogend@alpha.franken.de, p.zabel@pengutronix.de,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mips@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v7 1/5] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers
Date: Tue, 14 Feb 2023 07:10:11 -0800	[thread overview]
Message-ID: <20230214151011.GA742354@roeck-us.net> (raw)
In-Reply-To: <20230214103936.1061078-2-sergio.paracuellos@gmail.com>

On Tue, Feb 14, 2023 at 11:39:32AM +0100, Sergio Paracuellos wrote:
> MT7621 SoC provides a system controller node for accessing to some registers.
> Add a phandle in this node to avoid using MIPS related arch operations and
> includes in watchdog driver code.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml  | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> index b2b17fdf4e39..a668d0c2f14b 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> @@ -19,6 +19,12 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  mediatek,sysctl:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      phandle to system controller 'sysc' syscon node which
> +      controls system registers
> +
>  required:
>    - compatible
>    - reg
> @@ -30,4 +36,5 @@ examples:
>      watchdog@100 {
>        compatible = "mediatek,mt7621-wdt";
>        reg = <0x100 0x100>;
> +      mediatek,sysctl = <&sysc>;
>      };
> -- 
> 2.25.1
> 

  reply	other threads:[~2023-02-14 15:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 10:39 [PATCH v7 0/5] watchdog: mt7621-wdt: avoid globals and arch dependencies Sergio Paracuellos
2023-02-14 10:39 ` [PATCH v7 1/5] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers Sergio Paracuellos
2023-02-14 15:10   ` Guenter Roeck [this message]
2023-02-14 10:39 ` [PATCH v7 2/5] mips: dts: ralink: mt7621: rename watchdog node from 'wdt' into 'watchdog' Sergio Paracuellos
2023-02-14 15:11   ` Guenter Roeck
2023-02-14 15:12     ` Sergio Paracuellos
2023-02-28  4:44       ` Sergio Paracuellos
2023-02-28  8:39         ` Thomas Bogendoerfer
2023-02-28  8:51           ` Sergio Paracuellos
2023-02-28 14:55             ` Guenter Roeck
2023-02-28 15:46               ` Sergio Paracuellos
2023-02-28 22:15   ` Thomas Bogendoerfer
2023-02-14 10:39 ` [PATCH v7 3/5] mips: dts: ralink: mt7621: add phandle to system controller node for watchdog Sergio Paracuellos
2023-02-14 15:11   ` Guenter Roeck
2023-02-28 22:15   ` Thomas Bogendoerfer
2023-02-14 10:39 ` [PATCH v7 4/5] watchdog: mt7621-wdt: avoid static global declarations Sergio Paracuellos
2023-02-14 10:39 ` [PATCH v7 5/5] watchdog: mt7621-wdt: avoid ralink architecture dependent code Sergio Paracuellos
2023-02-14 15:11   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230214151011.GA742354@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arinc.unal@arinc9.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox