From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Support Opensource <support.opensource@diasemi.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Marcus Folkesson <marcus.folkesson@gmail.com>
Subject: [PATCH 3/4] watchdog: da9052_wdt: do not disable wdt during probe
Date: Thu, 13 Mar 2025 13:14:43 +0100 [thread overview]
Message-ID: <20250313-da9052-fixes-v1-3-379dc87af953@gmail.com> (raw)
In-Reply-To: <20250313-da9052-fixes-v1-0-379dc87af953@gmail.com>
If the watchog is started by the bootloader, we do not want the watchdog
to be disabled.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/watchdog/da9052_wdt.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c
index fa9078d4c136a52f1193768fe93dc04189519679..90b620b11b5fb634372e18ce4c40568cd946f284 100644
--- a/drivers/watchdog/da9052_wdt.c
+++ b/drivers/watchdog/da9052_wdt.c
@@ -194,13 +194,6 @@ static int da9052_wdt_probe(struct platform_device *pdev)
if (da9052->fault_log & DA9052_FAULTLOG_VDDFAULT)
da9052_wdt->bootstatus |= WDIOF_POWERUNDER;
- ret = da9052_reg_update(da9052, DA9052_CONTROL_D_REG,
- DA9052_CONTROLD_TWDSCALE, 0);
- if (ret < 0) {
- dev_err(dev, "Failed to disable watchdog bits, %d\n", ret);
- return ret;
- }
-
return devm_watchdog_register_device(dev, &driver_data->wdt);
}
--
2.48.1
next prev parent reply other threads:[~2025-03-13 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 12:14 [PATCH 0/4] Various fixes for the da9052 watchdog Marcus Folkesson
2025-03-13 12:14 ` [PATCH 1/4] watchdog: da9052_wdt: add support for nowayout Marcus Folkesson
2025-03-13 12:14 ` [PATCH 2/4] watchdog: da9052_wdt: use timeout value from external inputs Marcus Folkesson
2025-03-13 12:14 ` Marcus Folkesson [this message]
2025-03-14 7:32 ` [PATCH 3/4] watchdog: da9052_wdt: do not disable wdt during probe kernel test robot
2025-03-13 12:14 ` [PATCH 4/4] watchdog: da9052_wdt: respect TWDMIN Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313-da9052-fixes-v1-3-379dc87af953@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=support.opensource@diasemi.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox